Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uncomment and use get_asn #1320

Merged
merged 2 commits into from
Aug 6, 2024
Merged

uncomment and use get_asn #1320

merged 2 commits into from
Aug 6, 2024

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Jul 19, 2024

Fixes #1318

This PR uncomments get_asn and uses it in the 2 regtests I found that pull associations from artifactory.

This allows the regtests to be simplified by not requiring them to:

  • download files in an association in addition to the association
  • get_asn automatically sets the rtdata.input attribute so the test does not need to set this

Regression tests running:
https://github.com/spacetelescope/RegressionTests/actions/runs/10267768330

Checklist

  • added entry in CHANGES.rst under the corresponding subsection
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 12.50000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 78.56%. Comparing base (ee8288f) to head (c9ba2ff).
Report is 191 commits behind head on main.

Files with missing lines Patch % Lines
romancal/regtest/regtestdata.py 12.50% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1320      +/-   ##
==========================================
- Coverage   78.69%   78.56%   -0.14%     
==========================================
  Files         117      117              
  Lines        7844     7860      +16     
==========================================
+ Hits         6173     6175       +2     
- Misses       1671     1685      +14     
Flag Coverage Δ *Carryforward flag
nightly 62.26% <ø> (ø) Carriedforward from ee8288f

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram braingram marked this pull request as ready for review July 19, 2024 20:51
@braingram braingram requested a review from a team as a code owner July 19, 2024 20:51
@braingram

This comment was marked as outdated.

@braingram
Copy link
Collaborator Author

@ddavis-stsci I requested your review since using get_asn would simplify the regression test you're adding in #1222

Copy link
Collaborator

@mairanteodoro mairanteodoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, @braingram! Thanks!

@braingram braingram force-pushed the get_asn branch 2 times, most recently from 18d268f to 70eb70e Compare July 26, 2024 17:33
@braingram
Copy link
Collaborator Author

@mairanteodoro Thanks for taking a look. I'm seeing this PR as not approved. Is that intentional? If so, is there an issue to address or another person to approve it. Thanks again.

@mairanteodoro
Copy link
Collaborator

@mairanteodoro Thanks for taking a look. I'm seeing this PR as not approved. Is that intentional? If so, is there an issue to address or another person to approve it. Thanks again.

I was just deferring the approval to @ddavis-stsci. I will aprove it now.

Copy link
Collaborator

@mairanteodoro mairanteodoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @braingram!

@braingram
Copy link
Collaborator Author

Thanks!

@ddavis-stsci Does this look good to you? It will be useful for #1348

I'm happy to either wait until after #1348 is merged and then update this PR or merge this PR so you can update #1348

Copy link
Collaborator

@ddavis-stsci ddavis-stsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@mairanteodoro mairanteodoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@braingram
Copy link
Collaborator Author

braingram commented Aug 6, 2024

Thanks! I'm re-running the regtests now (same link as above).

EDIT: this needs a new run (and new link) due to the patch table environment variable changes
Run here: https://github.com/spacetelescope/RegressionTests/actions/runs/10267768330

@braingram
Copy link
Collaborator Author

Regtests all passed.

@braingram braingram merged commit ad54039 into spacetelescope:main Aug 6, 2024
25 of 27 checks passed
@braingram braingram deleted the get_asn branch August 6, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncomment and use get_asn
3 participants