Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rcal-827 Add reg test for DMS373 #1348

Merged
merged 5 commits into from
Aug 6, 2024

Conversation

ddavis-stsci
Copy link
Collaborator

@ddavis-stsci ddavis-stsci commented Aug 2, 2024

Resolves RCAL-827

Closes #1218

This PR adds a regression test for resampling data to a skycell (DMS 373). Currently it uses the SCSB skycell definitions but will be changed to the RTB definitions once available.

Checklist

  • added entry in CHANGES.rst under the corresponding subsection
  • updated relevant tests
  • [N/A] updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR

The passing regression tests are at
https://github.com/spacetelescope/RegressionTests/actions/runs/10219749253
and
https://github.com/spacetelescope/RegressionTests/actions/runs/10220085169

The only issue is that we will need to have
PATCH_TABLE_PATH=/grp/roman/scsb/tesselation/patches.asdf
added to the romancal.yml file for GitHub actions (https://github.com/spacetelescope/RegressionTests/pull/112) before merging.

Copy link
Collaborator

@schlafly schlafly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Please update the test ticket to have the file name used here. I think I would recommend including some sky cell and "valid" language in the log message to make more contact with the words in the test ticket.

@braingram braingram mentioned this pull request Aug 5, 2024
6 tasks
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.69%. Comparing base (af92054) to head (00876c5).
Report is 192 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1348   +/-   ##
=======================================
  Coverage   78.69%   78.69%           
=======================================
  Files         117      117           
  Lines        7844     7844           
=======================================
  Hits         6173     6173           
  Misses       1671     1671           
Flag Coverage Δ *Carryforward flag
nightly 62.26% <ø> (ø) Carriedforward from af92054

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ddavis-stsci ddavis-stsci merged commit ee8288f into spacetelescope:main Aug 6, 2024
23 checks passed
@ddavis-stsci ddavis-stsci deleted the rcal-827 branch August 6, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add resample to skycell to hlp regression test
2 participants