-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rcal-827 Add reg test for DMS373 #1348
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Please update the test ticket to have the file name used here. I think I would recommend including some sky cell and "valid" language in the log message to make more contact with the words in the test ticket.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1348 +/- ##
=======================================
Coverage 78.69% 78.69%
=======================================
Files 117 117
Lines 7844 7844
=======================================
Hits 6173 6173
Misses 1671 1671
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
for more information, see https://pre-commit.ci
Resolves RCAL-827
Closes #1218
This PR adds a regression test for resampling data to a skycell (DMS 373). Currently it uses the SCSB skycell definitions but will be changed to the RTB definitions once available.
Checklist
CHANGES.rst
under the corresponding subsectionThe passing regression tests are at
https://github.com/spacetelescope/RegressionTests/actions/runs/10219749253
and
https://github.com/spacetelescope/RegressionTests/actions/runs/10220085169
The only issue is that we will need to have
PATCH_TABLE_PATH=/grp/roman/scsb/tesselation/patches.asdf
added to the romancal.yml file for GitHub actions (https://github.com/spacetelescope/RegressionTests/pull/112) before merging.