Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the number of tests for supported catalog formats. #1496

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Reduce the number of tests for supported catalog formats. #1496

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f050398
Reduce number of supported formats.
mairanteodoro Nov 5, 2024
b353854
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 1 addition & 18 deletions romancal/tweakreg/tests/test_astrometric_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,24 +474,7 @@ def test_create_astrometric_catalog_write_results_to_disk(tmp_path, base_image):
fh = StringIO()
table.Table.write.list_formats(out=fh)
fh.seek(0)
list_of_supported_formats = [
x.strip().split()[0]
for x in fh.readlines()[2:]
if x.strip().split()[1].lower() == "yes"
]
# exclude data formats
[
list_of_supported_formats.remove(x)
for x in [
"asdf",
"fits",
"hdf5",
"parquet",
"pandas.html",
"pandas.json",
"pandas.csv",
]
]
list_of_supported_formats = ["ascii.ecsv", "fits"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would be required to add asdf?


for table_format in list_of_supported_formats:
res = create_astrometric_catalog(
Expand Down
Loading