Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jump documentation (RCAL-115) #249

Closed
wants to merge 2 commits into from
Closed

Add Jump documentation (RCAL-115) #249

wants to merge 2 commits into from

Conversation

dmggh
Copy link
Contributor

@dmggh dmggh commented Jul 7, 2021

Closes #

Resolves RCAL-115

Description
Documentation for the jump detection step (RCAL-115).

This PR addresses ...

Checklist

  • Tests

  • [X ] Documentation

  • Change log

  • Milestone

  • Label(s)

@dmggh dmggh added the documentation Improvements or additions to documentation label Jul 7, 2021
@dmggh dmggh requested a review from ddavis-stsci July 7, 2021 07:54
@dmggh dmggh self-assigned this Jul 7, 2021
@codecov
Copy link

codecov bot commented Jul 7, 2021

Codecov Report

Merging #249 (f0732be) into main (f4ff08e) will decrease coverage by 11.78%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #249       +/-   ##
===========================================
- Coverage   58.16%   46.38%   -11.79%     
===========================================
  Files          36       35        -1     
  Lines         753      746        -7     
===========================================
- Hits          438      346       -92     
- Misses        315      400       +85     
Flag Coverage Δ
nightly ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
romancal/flatfield/flat_field.py 26.47% <0.00%> (-64.71%) ⬇️
romancal/flatfield/flat_field_step.py 28.00% <0.00%> (-56.00%) ⬇️
romancal/regtest/regtestdata.py 27.04% <0.00%> (-27.56%) ⬇️
romancal/stpipe/core.py 80.00% <0.00%> (-13.34%) ⬇️
setup.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4ff08e...f0732be. Read the comment docs.

Copy link
Collaborator

@ddavis-stsci ddavis-stsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@dmggh dmggh mentioned this pull request Jul 20, 2021
4 tasks
Copy link
Collaborator

@nden nden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmggh Is this superseded by #257? If so please close it.

@dmggh
Copy link
Contributor Author

dmggh commented Jul 23, 2021

Superseded by #257 so closing.

@dmggh dmggh closed this Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants