Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jump documentation (RCAL-115) #257

Merged
merged 3 commits into from
Jul 23, 2021
Merged

Conversation

dmggh
Copy link
Contributor

@dmggh dmggh commented Jul 21, 2021

Closes #

Resolves RCAL-115

Description

This PR addresses jump documentation for the jump detection step in Roman.

Checklist

  • Tests

  • [X ] Documentation

  • Change log

  • Milestone

  • Label(s)

@dmggh dmggh added documentation Improvements or additions to documentation jump labels Jul 21, 2021
@dmggh dmggh requested a review from ddavis-stsci July 21, 2021 03:07
@dmggh dmggh self-assigned this Jul 21, 2021
@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #257 (c51c89d) into main (b2628d1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #257   +/-   ##
=======================================
  Coverage   46.38%   46.38%           
=======================================
  Files          35       35           
  Lines         746      746           
=======================================
  Hits          346      346           
  Misses        400      400           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2628d1...c51c89d. Read the comment docs.

Copy link
Collaborator

@ddavis-stsci ddavis-stsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text looks good but the sphinx error does need to be addressed.

Copy link
Collaborator

@ddavis-stsci ddavis-stsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmggh dmggh merged commit 4d66cfd into spacetelescope:main Jul 23, 2021
@nden nden added this to the Build 0.3 milestone Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation jump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants