Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test against nightly builds of astropy, scipy, and numpy #695

Merged
merged 1 commit into from
May 9, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion requirements-dev.txt
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
git+https://github.com/asdf-format/asdf
git+https://github.com/asdf-format/asdf-transform-schemas
git+https://github.com/asdf-format/asdf-wcs-schemas
git+https://github.com/astropy/astropy
astropy>=0.0.dev0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is actually exactly counter to the purpose of testing against a "nightly build" for astropy. Note that as far as I am aware, there are no "nightly builds" for astropy.

The previous configuration will use the latest dev version (literally the head of astropy's main branch). This by definition will cover all changes included in any astropy release candidate.

git+https://github.com/astropy/asdf-astropy
git+https://github.com/spacetelescope/crds
git+https://github.com/spacetelescope/gwcs
numpy>=0.0.dev0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change does absolutely nothing in the context of the rest of the changes here. In fact, one can see in the CI: https://github.com/spacetelescope/romancal/actions/runs/4926111203/jobs/8801225303#step:10:265 that it is using numpy 1.24.3 which is the latest release version of numpy NOT some "nightly-build".

If you want to use this to actually access the nightly builds (which in reality are more like weekly builds), you need to specify an alternate index for pip to search.

For example https://github.com/astropy/astropy/blob/337798f36c9aa2ae98190c5819bde758d3aa5a40/tox.ini#L27 specifies the "nightly-build" provided by anaconda.

git+https://github.com/spacetelescope/roman_datamodels
scipy>=0.0.dev0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as numpy comment.

git+https://github.com/spacetelescope/stpipe
git+https://github.com/spacetelescope/stcal
git+https://github.com/spacetelescope/tweakwcs