-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update jump detection for stcal changes #723
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #723 +/- ##
==========================================
- Coverage 75.72% 75.70% -0.02%
==========================================
Files 90 90
Lines 5478 5478
==========================================
- Hits 4148 4147 -1
- Misses 1330 1331 +1
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Regression tests with currently release stcal shows no errors: Run with stcal main show failures for ramp fitting: test_one_group_small_buffer_fit_ols (all 4 parameterizations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, if you could add the Roman-Developers-Pull-Requests link #257 to the checklist.
I'll take care of the ramp fit errors you are seeing.
Can you also change pyproject.toml to pin 'stcal >=1.4.0', |
Thanks for taking a look at this and thanks for looking into the ramp fitting changes. Anything I can do to help finish up this PR? |
I think we're good to go! |
stcal recently updated jump detection and ramp fitting.
https://github.com/spacetelescope/stcal/releases/tag/1.4.0
This PR only addresses the jump detection changes (which changed the number of returned values).
The new returned values are ignored in this PR to fix the errors introduced by these changes.
I am not familiar with the arguments or return values for this function so a check for validity (and not just relying on a lack of failures) is needed.
Checklist
CHANGES.rst
under the corresponding subsectionRegression tests run (against stcal main which is now released):
https://plwishmaster.stsci.edu:8081/blue/organizations/jenkins/RT%2FRoman-Developers-Pull-Requests/detail/Roman-Developers-Pull-Requests/257/pipeline/206/