Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

split requirements-dev.txt into first and third party dev dependencies #840

Merged
merged 7 commits into from
Sep 21, 2023
Merged

split requirements-dev.txt into first and third party dev dependencies #840

merged 7 commits into from
Sep 21, 2023

Conversation

zacharyburnett
Copy link
Collaborator

This PR splits the dev dependencies into requirements-dev.txt and requirements-dev-thirdparty.txt

Checklist

  • added entry in CHANGES.rst under the corresponding subsection
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

@zacharyburnett zacharyburnett self-assigned this Aug 21, 2023
@zacharyburnett zacharyburnett requested a review from a team as a code owner August 21, 2023 17:09
@zacharyburnett zacharyburnett marked this pull request as draft August 21, 2023 17:09
@github-actions github-actions bot added testing dependencies Pull requests that update a dependency file regression_testing automation labels Aug 21, 2023
@codecov
Copy link

codecov bot commented Aug 21, 2023 •
edited
Loading

Codecov Report

Patch has no changes to coverable lines.

📢 Thoughts on this report? Let us know!.

@zacharyburnett
Copy link
Collaborator Author

zacharyburnett commented Aug 21, 2023 •
edited
Loading

wait until #843 to incorporate those changes as well

@zacharyburnett zacharyburnett force-pushed the deps/separate_dev branch 2 times, most recently from 43fbdf9 to c9fba6b Compare August 21, 2023 19:48
@zacharyburnett zacharyburnett marked this pull request as ready for review August 22, 2023 13:28
@zacharyburnett zacharyburnett changed the title separate first and third party dev dependencies into requirements.txt files separate requirements-dev.txt into first and third party dev dependencies Aug 29, 2023
@zacharyburnett zacharyburnett changed the title separate requirements-dev.txt into first and third party dev dependencies split requirements-dev.txt into first and third party dev dependencies Aug 29, 2023
WilliamJamieson
WilliamJamieson requested changes Aug 29, 2023
View reviewed changes
zacharyburnett
zacharyburnett commented Sep 11, 2023
View reviewed changes
schlafly
schlafly approved these changes Sep 20, 2023
View reviewed changes
Copy link
Collaborator

@schlafly schlafly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, though I'm mostly deferring to the experts!

@schlafly
Copy link
Collaborator

@zacharyburnett , can we add a changelog entry and then go ahead and merge this?

@ddavis-stsci
Copy link
Collaborator

ddavis-stsci commented Sep 20, 2023 •
edited
Loading

@zacharyburnett , can we add a changelog entry and then go ahead and merge this?

The change log is fine but we also need an update to the README.md to explain to the users how to use the new files when installing the software.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 21, 2023
zacharyburnett
zacharyburnett commented Sep 21, 2023
View reviewed changes
README.md
Comment on lines +105 to +109
Development versions of dependencies are listed in `requirements-dev-st.txt` and `requirements-dev-thirdparty.txt`, containing STScI and third-party packages respectively.
To install these dependencies, run the following:

pip install -r requirements-dev-st.txt
pip install -r requirements-dev-thirdparty.txt
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how is this?

ddavis-stsci
ddavis-stsci approved these changes Sep 21, 2023
View reviewed changes
Copy link
Collaborator

@ddavis-stsci ddavis-stsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zacharyburnett zacharyburnett merged commit 9e80829 into spacetelescope:main Sep 21, 2023
@zacharyburnett zacharyburnett deleted the deps/separate_dev branch September 21, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schlafly schlafly schlafly approved these changes

@ddavis-stsci ddavis-stsci ddavis-stsci approved these changes

@WilliamJamieson WilliamJamieson Awaiting requested review from WilliamJamieson

Assignees

@zacharyburnett zacharyburnett

Labels
automation dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation no-changelog-entry-needed regression_testing run scheduled tests testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zacharyburnett @schlafly @ddavis-stsci @WilliamJamieson @nden