Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split requirements-dev.txt into first and third party dev dependencies #840

Merged
merged 7 commits into from
Sep 21, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/roman_ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ jobs:
- linux: check-dependencies
- linux: build-dist
test:
uses: OpenAstronomy/github-actions-workflows/.github/workflows/tox.yml@main
uses: OpenAstronomy/github-actions-workflows/.github/workflows/tox.yml@v1
needs: [ data ]
with:
setenv: |
Expand Down
8 changes: 6 additions & 2 deletions JenkinsfileRT
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,8 @@ bc0.build_cmds = bc0.build_cmds + [
"pip list"
]
bc0.test_cmds = [
"pytest --cov-report=xml:coverage.xml --cov=./ -r sxf -n auto --bigdata --slow \
"pytest -r sxf -n auto --bigdata --slow \
--cov --cov-report=xml:coverage.xml \
--ddtrace \
--basetemp=${pytest_basetemp} --junit-xml=results.xml --dist=loadscope \
--env=${artifactoryenv} ${pytest_args}",
Expand All @@ -119,5 +120,8 @@ bc1.build_cmds = bc1.build_cmds + PipInject(env.OVERRIDE_REQUIREMENTS)
bc1.test_cmds = []
bc1.test_configs = []

utils.run([jobconfig, bc0, bc1])
bc2 = utils.copy(bc0)
bc2.pip_reqs_files = ['requirements-sdp.txt', 'requirements-dev-st.txt']

utils.run([jobconfig, bc0, bc1, bc2])
} // withCredentials
7 changes: 5 additions & 2 deletions JenkinsfileRT_dev
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ bc0.conda_packages = [
"python=${python_version}",
"freetds",
]
bc0.pip_reqs_files = ['requirements-dev.txt']
bc0.pip_reqs_files = ['requirements-dev-thirdparty.txt']
bc0.build_cmds = [
"pip install -e .[test]",
"pip install pytest-xdist pytest-sugar",
Expand Down Expand Up @@ -109,5 +109,8 @@ bc1.build_cmds = bc1.build_cmds + PipInject(env.OVERRIDE_REQUIREMENTS)
bc1.test_cmds = []
bc1.test_configs = []

utils.run([jobconfig, bc0, bc1])
bc2 = utils.copy(bc0)
bc2.pip_reqs_files = ['requirements-dev-thirdparty.txt', 'requirements-dev-st.txt']

utils.run([jobconfig, bc0, bc1, bc2])
} // withCredentials
6 changes: 6 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,12 @@ tools used for linting and reproducible environments run:

This will install `tox` and the `pre-commit` tools in addition to all development dependencies.

Development versions of dependencies are listed in `requirements-dev-st.txt` and `requirements-dev-thirdparty.txt`, containing STScI and third-party packages respectively.
To install these dependencies, run the following:

pip install -r requirements-dev-st.txt
pip install -r requirements-dev-thirdparty.txt
Comment on lines +105 to +109
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how is this?


Need other useful packages in your development environment?

pip install ipython pytest-xdist
Expand Down
13 changes: 13 additions & 0 deletions requirements-dev-st.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# Roman upstream packages
git+https://github.com/spacetelescope/roman_datamodels
git+https://github.com/spacetelescope/rad

# shared upstream packages
git+https://github.com/spacetelescope/stcal
git+https://github.com/spacetelescope/stpipe

# Other important upstream packages
git+https://github.com/spacetelescope/crds
git+https://github.com/spacetelescope/gwcs
git+https://github.com/spacetelescope/metrics_logger
git+https://github.com/spacetelescope/tweakwcs
18 changes: 4 additions & 14 deletions requirements-dev.txt → requirements-dev-thirdparty.txt
Original file line number Diff line number Diff line change
@@ -1,26 +1,16 @@
# ASDF upstream packages
git+https://github.com/asdf-format/asdf-standard
git+https://github.com/asdf-format/asdf
git+https://github.com/asdf-format/asdf-transform-schemas
git+https://github.com/asdf-format/asdf-coordinates-schemas
git+https://github.com/asdf-format/asdf-wcs-schemas
git+https://github.com/astropy/asdf-astropy

# Use weekly astropy dev build
git+https://github.com/astropy/asdf-astropy
--extra-index-url https://pypi.anaconda.org/astropy/simple astropy --pre
git+https://github.com/astropy/photutils.git

# Use Bi-weekly numpy/scipy dev builds
--extra-index-url https://pypi.anaconda.org/scientific-python-nightly-wheels/simple
numpy>=0.0.dev0
scipy>=0.0.dev0

# Roman upstream packages
git+https://github.com/spacetelescope/roman_datamodels
git+https://github.com/spacetelescope/rad

# Other important upstream packages
git+https://github.com/spacetelescope/gwcs
git+https://github.com/spacetelescope/stpipe
git+https://github.com/spacetelescope/crds
git+https://github.com/spacetelescope/stcal
git+https://github.com/spacetelescope/tweakwcs
git+https://github.com/spacetelescope/metrics_logger
git+https://github.com/astropy/photutils.git
9 changes: 4 additions & 5 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@ commands =
description =
run tests
alldeps: with all optional dependencies
devdeps: with the latest developer version of key dependencies
stdevdeps: with the latest developer version of key upstream spacetelescope dependencies
devdeps: with the latest developer version of key upstream third-party dependencies
oldestdeps: with the oldest supported version of key dependencies
sdpdeps: with the recent STScI DMS release pinned dependencies
pyargs: with --pyargs on installed package
Expand All @@ -54,9 +55,6 @@ pass_env =
CODECOV_*
DD_*
WEBBPSF_PATH
set_env =
devdeps: PIP_EXTRA_INDEX_URL = https://pypi.anaconda.org/scientific-python-nightly-wheels/simpl

extras =
test
alldeps: all
Expand All @@ -67,7 +65,8 @@ deps =
commands_pre =
oldestdeps: minimum_dependencies romancal --filename requirements-min.txt
oldestdeps: pip install -r requirements-min.txt
devdeps: pip install -r requirements-dev.txt -U --upgrade-strategy eager
stdevdeps: pip install -r requirements-dev-st.txt -U --upgrade-strategy eager
devdeps: pip install -r requirements-dev-thirdparty.txt -r requirements-dev-st.txt -U --upgrade-strategy eager
sdpdeps: pip install -r requirements-sdp.txt
pip list
commands =
Expand Down