Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get_crds_parameters for ModelContainer #846

Merged
merged 2 commits into from
Aug 23, 2023
Merged

Fix get_crds_parameters for ModelContainer #846

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e3fbf8
FIx the get_crds_parameters method
WilliamJamieson Aug 22, 2023
af5be2d
Update changes
WilliamJamieson Aug 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
0.13.0 (unreleased)
===================

-
general
-------

- Fix bug with ``ModelContainer.get_crds_parameters`` being a property not a method [#846]

0.12.0 (2023-08-18)
===================
Expand Down
1 change: 0 additions & 1 deletion romancal/datamodels/container.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,7 +512,6 @@ def crds_observatory(self):
"""
return "roman"

@property
def get_crds_parameters(self):
"""
Get parameters used by CRDS to select references for this model.
Expand Down
10 changes: 2 additions & 8 deletions romancal/datamodels/tests/test_datamodels.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,17 +359,11 @@ def test_get_crds_parameters(n, obj_type, tmp_path, request):
n, obj_type, tmp_path
)

mc = ModelContainer(filepath_list)

res = mc.get_crds_parameters

assert isinstance(res, dict)
assert isinstance(ModelContainer(filepath_list).get_crds_parameters(), dict)


def test_get_crds_parameters_empty():
mc = ModelContainer()

crds_param = mc.get_crds_parameters
crds_param = ModelContainer().get_crds_parameters()

assert isinstance(crds_param, dict)
assert len(crds_param) == 0
Expand Down