-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for roman ramp data #43
Conversation
Codecov Report
@@ Coverage Diff @@
## main #43 +/- ##
==========================================
- Coverage 40.88% 40.84% -0.04%
==========================================
Files 14 14
Lines 2118 2120 +2
==========================================
Hits 866 866
- Misses 1252 1254 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The Roman
RampModel
is missingmeta.exposure.drop_frames1
andmodel.int_times
.This adds a check that those attributes exist before attempting to access them.