Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for roman ramp data #43

Merged
merged 2 commits into from
Aug 26, 2021
Merged

Conversation

nden
Copy link
Collaborator

@nden nden commented Aug 20, 2021

The Roman RampModel is missing meta.exposure.drop_frames1 and model.int_times.
This adds a check that those attributes exist before attempting to access them.

@codecov
Copy link

codecov bot commented Aug 20, 2021

Codecov Report

Merging #43 (7246b23) into main (16036a2) will decrease coverage by 0.03%.
The diff coverage is 11.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
- Coverage   40.88%   40.84%   -0.04%     
==========================================
  Files          14       14              
  Lines        2118     2120       +2     
==========================================
  Hits          866      866              
- Misses       1252     1254       +2     
Impacted Files Coverage Δ
src/stcal/ramp_fitting/ramp_fit.py 37.93% <0.00%> (ø)
src/stcal/ramp_fitting/ramp_fit_class.py 12.82% <13.33%> (-0.70%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16036a2...7246b23. Read the comment docs.

Copy link
Collaborator

@kmacdonald-stsci kmacdonald-stsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@nden nden requested a review from ddavis-stsci August 25, 2021 18:42
Copy link
Collaborator

@ddavis-stsci ddavis-stsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nden nden merged commit 0ad675c into spacetelescope:main Aug 26, 2021
nden added a commit that referenced this pull request Aug 27, 2021
nden added a commit that referenced this pull request Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants