Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Adds support for roman ramp data" #48

Merged
merged 1 commit into from
Aug 27, 2021
Merged

Conversation

nden
Copy link
Collaborator

@nden nden commented Aug 27, 2021

Reverts #43

Broke jwst.
The attribute check should not be done in the RampClass methods only at the initial creation of the RampClass from a data model.

@nden nden requested a review from kmacdonald-stsci August 27, 2021 15:38
@codecov
Copy link

codecov bot commented Aug 27, 2021

Codecov Report

Merging #48 (38bd305) into main (0373a76) will increase coverage by 0.03%.
The diff coverage is 13.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
+ Coverage   37.73%   37.77%   +0.03%     
==========================================
  Files          14       14              
  Lines        2120     2118       -2     
==========================================
  Hits          800      800              
+ Misses       1320     1318       -2     
Impacted Files Coverage Δ
src/stcal/ramp_fitting/ramp_fit.py 37.93% <0.00%> (ø)
src/stcal/ramp_fitting/ramp_fit_class.py 13.51% <15.38%> (+0.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0373a76...38bd305. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants