Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates nirspec cubepar reference to use driz wavelength table #157

Closed
wants to merge 2 commits into from
Closed

Updates nirspec cubepar reference to use driz wavelength table #157

wants to merge 2 commits into from

Conversation

jemorrison
Copy link
Contributor

@jemorrison jemorrison commented Apr 20, 2023 •
edited by hbushouse
Loading

Resolves JP-3047

This PR updates the jwst cubepars reference file data model to include wavelength arrays for the drizzle weighting method.

Checklist

  • added entry in CHANGES.rst (either in Bug Fixes or Changes to API)
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

@jemorrison jemorrison requested a review from a team as a code owner April 20, 2023 19:05
@codecov
Copy link

codecov bot commented Apr 20, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (d06902b) 63.88% compared to head (95570d5) 63.88%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #157   +/-   ##
=======================================
  Coverage   63.88%   63.88%           
=======================================
  Files          99       99           
  Lines        5486     5486           
=======================================
  Hits         3505     3505           
  Misses       1981     1981
Impacted Files Coverage Δ
src/stdatamodels/jwst/datamodels/ifucubepars.py 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

hbushouse
hbushouse reviewed Apr 25, 2023
View reviewed changes
Copy link
Contributor

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Model updates look OK. Needs a change log entry.

@hbushouse hbushouse mentioned this pull request Apr 25, 2023
Merged
7 tasks
nden
nden reviewed Apr 25, 2023
View reviewed changes
src/stdatamodels/jwst/datamodels/ifucubepars.py Outdated
@@ -35,6 +35,15 @@ class NirspecIFUCubeParsModel(ReferenceFileModel):

ifucubepars_high_emsm_wavetable : numpy table
default IFU cube high resolution emsm wavetable

ifucubepars_prism_driz_wavetable : numpy table
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is a numpy table?

@jemorrison
Copy link
Contributor Author

I can still NOT get stdatamodels pip installed. I can not fully test this change until the error is one.
DO NOT MERGE YET. I need to test and then we need to get the new cubepars file into CRDS.

I still get an error: ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
jwst 1.10.2.dev16+gc1c575c15.d20230426 requires stdatamodels<1.4.1,>=1.4.0, but you have stdatamodels 1.4.1.dev3+g95570d5 which is incompatible.

@WilliamJamieson WilliamJamieson mentioned this pull request Apr 27, 2023
Merged
2 tasks
@zacharyburnett zacharyburnett mentioned this pull request Apr 28, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nden nden nden left review comments

@hbushouse hbushouse hbushouse left review comments

Assignees
No one assigned
Labels
jwst datamodels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jemorrison @nden @hbushouse