Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3449: Add TMEASURE keyword to core schema #248

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

emolter
Copy link
Contributor

@emolter emolter commented Jan 22, 2024

Resolves JP-3449

Closes [spacetelescope/jwst#8036]

This PR addresses adding TMEASURE to the JWST core schema.

Checklist

  • added entry in CHANGES.rst (either in Bug Fixes or Changes to API)
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

Sorry, something went wrong.

@emolter emolter marked this pull request as ready for review January 22, 2024 19:12
@emolter emolter requested a review from a team as a code owner January 22, 2024 19:12
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d3fce42) 64.84% compared to head (264bb2d) 64.84%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #248   +/-   ##
=======================================
  Coverage   64.84%   64.84%           
=======================================
  Files         103      103           
  Lines        5694     5694           
=======================================
  Hits         3692     3692           
  Misses       2002     2002           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@braingram braingram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Schema changes look good to me. Thanks for making this update!

Is there a jwst PR to populate and/or use the new keyword?

@emolter
Copy link
Contributor Author

emolter commented Jan 23, 2024

I am working on JP-3465 but it isn't ready yet; here's a link to the draft PR.

@hbushouse hbushouse changed the title fixes JP-3449 JP-3449: Add TMEASURE keyword to core schema Jan 24, 2024
@hbushouse hbushouse added this to the 1.9.1 milestone Jan 24, 2024
@hbushouse
Copy link
Contributor

@braingram This keyword will be populated by SDP code during level-1b processing, just like all the other time-related keywords. There is an existing JSDP ticket to compute the value and populate it, and a JWSTKD ticket to add the definition to the official JWST keyword dictionary. So all bases are covered.

@hbushouse
Copy link
Contributor

All the CI failures seem to be due to the same test "test_crds_selectors_vs_datamodel[miri]" and appear to be having a problem with model.meta.exposure.ngroups. No idea why this change would be causing that failure. I've checked the new lines in the core.schema.yaml lines closely and I don't see any syntax errors that would cause other failures in the schema.

@tapastro
Copy link
Collaborator

tapastro commented Jan 24, 2024

All the CI failures seem to be due to the same test "test_crds_selectors_vs_datamodel[miri]" and appear to be having a problem with model.meta.exposure.ngroups. No idea why this change would be causing that failure. I've checked the new lines in the core.schema.yaml lines closely and I don't see any syntax errors that would cause other failures in the schema.

This was caused by a CRDS update that didn't have a matching datamodel update, addressed in #249.

@tapastro tapastro force-pushed the main branch 2 times, most recently from 051be5f to d33833b Compare January 24, 2024 18:56
Copy link
Contributor

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good now. All CI tests pass.

@hbushouse hbushouse merged commit 8bbfe71 into spacetelescope:main Jan 24, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants