-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JP-3449: Add TMEASURE keyword to core schema #248
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #248 +/- ##
=======================================
Coverage 64.84% 64.84%
=======================================
Files 103 103
Lines 5694 5694
=======================================
Hits 3692 3692
Misses 2002 2002 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Schema changes look good to me. Thanks for making this update!
Is there a jwst PR to populate and/or use the new keyword?
I am working on JP-3465 but it isn't ready yet; here's a link to the draft PR. |
@braingram This keyword will be populated by SDP code during level-1b processing, just like all the other time-related keywords. There is an existing JSDP ticket to compute the value and populate it, and a JWSTKD ticket to add the definition to the official JWST keyword dictionary. So all bases are covered. |
All the CI failures seem to be due to the same test "test_crds_selectors_vs_datamodel[miri]" and appear to be having a problem with model.meta.exposure.ngroups. No idea why this change would be causing that failure. I've checked the new lines in the core.schema.yaml lines closely and I don't see any syntax errors that would cause other failures in the schema. |
This was caused by a CRDS update that didn't have a matching datamodel update, addressed in #249. |
051be5f
to
d33833b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good now. All CI tests pass.
Resolves JP-3449
Closes [spacetelescope/jwst#8036]
This PR addresses adding TMEASURE to the JWST core schema.
Checklist
CHANGES.rst
(either inBug Fixes
orChanges to API
)