Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3520: Add ngroups to mask schema #249

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Jan 23, 2024

Addresses JP-3520

Closes [spacetelescope/jwst#8219]

crds added 'ngroups' as a parkey for mask reference files. This is causing test failures (that check the schema and parkeys).

See the test failure here: https://github.com/asdf-format/asdf/actions/runs/7629799922/job/20784057576?pr=1739#step:10:718

This PR adds 'ngroups' to the mask schema to bring these two projects into alignment.

Checklist

  • added entry in CHANGES.rst (either in Bug Fixes or Changes to API)
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

@braingram braingram marked this pull request as ready for review January 23, 2024 18:37
@braingram braingram requested a review from a team as a code owner January 23, 2024 18:37
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (051be5f) 64.84% compared to head (a030cda) 64.84%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #249   +/-   ##
=======================================
  Coverage   64.84%   64.84%           
=======================================
  Files         103      103           
  Lines        5694     5694           
=======================================
  Hits         3692     3692           
  Misses       2002     2002           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram braingram force-pushed the add_ngroups_to_mask branch from fe02c98 to a030cda Compare January 23, 2024 18:43
@braingram braingram requested a review from tapastro January 23, 2024 19:16
@tapastro tapastro changed the title add ngroups to mask schema JP-3520: Add ngroups to mask schema Jan 24, 2024
Copy link
Collaborator

@tapastro tapastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great breadcrumb!

@braingram braingram merged commit d3fce42 into spacetelescope:main Jan 24, 2024
22 checks passed
@braingram braingram deleted the add_ngroups_to_mask branch January 24, 2024 16:12
@hbushouse hbushouse added this to the 1.9.1 milestone Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants