fix(css-selector): default XML namespace should not be applied to wildcard #3413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
should have been removed in f6eede5
When performing a CSS selector query, an XML document's root namespace declarations are injected into the XPathVisitor, and the default namespace is applied to any non-namespaced element in the resulting xpath query. However, the wildcard selector "*" should not have this namespace applied. This regressed in v1.17.0 with 179d74d. Fixes #3411
this time, it's the ruby:alpine images that removed all the -dev libraries. JFC i'm just trying to stay green here.
flavorjones
force-pushed
the
flavorjones-3411-xml-css-search
branch
from
68cf827 to
671462f
Compare
flavorjones
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
When performing a CSS selector query, an XML document's root namespace declarations are injected into the XPathVisitor, and the default namespace is applied to any non-namespaced element in the resulting xpath query.
However, the wildcard selector "*" should not have this namespace applied. This regressed in v1.17.0 with 179d74d.
Fixes #3411
Have you included adequate test coverage?
Yes.
Does this change affect the behavior of either the C or the Java implementations?
N/A