Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport: fix(css-selector): default XML namespace should not be applied to wildcard #3414

Merged
merged 4 commits into from
Jan 19, 2025

Conversation

flavorjones
Copy link
Member

Backport of #3413 to v1.18.x

When performing a CSS selector query, an XML document's root namespace
declarations are injected into the XPathVisitor, and the default
namespace is applied to any non-namespaced element in the resulting
xpath query.

However, the wildcard selector "*" should not have this namespace
applied. This regressed in v1.17.0 with 179d74d.

Fixes #3411
this time, it's the ruby:alpine images that removed all the -dev
libraries. JFC i'm just trying to stay green here.
@flavorjones flavorjones added this to the v1.18.x patch releases milestone Jan 19, 2025
@flavorjones flavorjones added the backport Backport of a PR to the current release branch label Jan 19, 2025
@flavorjones flavorjones enabled auto-merge January 19, 2025 18:45
now that rubyinstaller has been released
@flavorjones flavorjones disabled auto-merge January 19, 2025 20:13
@flavorjones flavorjones merged commit 0fb5541 into v1.18.x Jan 19, 2025
143 of 144 checks passed
@flavorjones flavorjones deleted the flavorjones-backport-3413 branch January 19, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Backport of a PR to the current release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant