Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lastest version of swagger-spec-validator (2.3.1) breaks master build #612

Closed
dtkav opened this issue Jul 2, 2018 · 0 comments
Closed

Comments

@dtkav
Copy link
Collaborator

dtkav commented Jul 2, 2018

Description

The latest version of swagger-spec-validator now validates that defaults are the correct type.
Since the library is not pinned, the release has broken master.

(tests/test_api.py::test_other_errors_stop_application_to_setup) relies on the old behavior (don't exit on default type errors if app(debug=true))
Also, one of the test fixtures has a (type: array) without an items: ... block, which is now invalid.

Additional info:

#611 fixes the build by upgrading to the latest version.
An alternate approach would be to pin to 2.0.2 of swagger-spec-validator
Let me know if that's preferred and I can put up a PR.

dtkav pushed a commit to dtkav/connexion that referenced this issue Jul 2, 2018
@jmcs jmcs closed this as completed in 0b19ed4 Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant