Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to swagger-spec-validator 2.3.1 (fixes #612) #611

Merged
merged 1 commit into from
Jul 3, 2018

Conversation

dtkav
Copy link
Collaborator

@dtkav dtkav commented Jul 2, 2018

Master is boken because of an update to swagger-spec-validator. This upgrades to the latest version and should fix the build.

Changes proposed in this pull request:

  • upgrade to swagger-spec-validator 2.3.1
  • debug=true will no longer continue if an operation has invalid defaults (change was in swagger-spec-validator)

@dtkav dtkav changed the title Upgrade to swagger-spec-validator 2.3.1 Upgrade to swagger-spec-validator 2.3.1 (fixes #612) Jul 2, 2018
@hjacobs
Copy link
Contributor

hjacobs commented Jul 2, 2018

Is there any way to get the debug=true behavior back? It's pretty useful for quick iterations during development when the spec is being changed and temporarily (partly) broken.

@dtkav
Copy link
Collaborator Author

dtkav commented Jul 2, 2018

@hjacobs I can hard-pin (==) to 2.0.1 instead to preserve the previous behavior if you prefer that.

The only real change here is that default validation happens earlier. Personally I'd prefer for it to crash as early as possible when the spec is wrong, because then you know the problem is unrelated to connexion, and there are several tools available for debugging invalid specs.

The previous behavior would have avoided crashing in Operation.validate_defaults(), which also made sense given the lack of functionality in the spec validator.

Another way to handle you request would be to ignore all validation errors in apis/abstract.py, but that seems like a recipe for heaps of stack traces 🙂 .

@hjacobs
Copy link
Contributor

hjacobs commented Jul 2, 2018

👍

@hjacobs hjacobs requested a review from jmcs July 2, 2018 12:55
@jmcs
Copy link
Contributor

jmcs commented Jul 3, 2018

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants