Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn off style-dfn-panel for WHATWG #1772

Merged
merged 2 commits into from
Oct 2, 2020
Merged

Turn off style-dfn-panel for WHATWG #1772

merged 2 commits into from
Oct 2, 2020

Conversation

andreubotella
Copy link
Contributor

See whatwg/whatwg.org#343, which moves those styles into WHATWG's standard.css stylesheet.

andreubotella pushed a commit to andreubotella/whatwg.org that referenced this pull request Sep 25, 2020
Add Bikeshed's style-dfn-panels styles to standard.css
ea2a6f5 
This change additionally modifies two rules from Bikeshed's styles
regarding <b> elements, for integration with the dfn panels in the HTML
spec, which use <p> instead.

See speced/bikeshed#1772, which turns off Bikeshed's style-dfn-panels
styles, and whatwg/html#5947, which modifies HTML's html-dfn.js script
to work with these styles.
@andreubotella andreubotella mentioned this pull request Sep 25, 2020
Merged
@tabatkins
Copy link
Collaborator

I presume I should wait to merge this until the WHATWG pr is merged, so it doesnt' go without styling.

If Anne or Domenic want to merge them together, feel free.

@annevk
Copy link
Collaborator

annevk commented Sep 28, 2020

We should also change defaults-RD.include.

I can take care of merging this once all is in order.

@andreubotella
Copy link
Contributor Author

andreubotella commented Sep 28, 2020 •
edited
Loading

We should also change defaults-RD.include.

I was under the impression that "Use Dfn Panels": "no" already disabled the styles, but I see I was wrong.

Btw, when I went to test this, defaults-RD.include was failing to parse because it was missing a comma. @tabatkins, you might want to add tests to catch this sort of stuff in the review drafts.

@tabatkins
Copy link
Collaborator

I was under the impression that "Use Dfn Panels": "no" already disabled the styles, but I see I was wrong.

Ah, this is because the use of dfn panels in the Index Of Externally-Defined Terms is not controlled by that metadata, but rather happens unconditionally.

I presume that should be similarly controlled?

@annevk
Copy link
Collaborator

annevk commented Sep 29, 2020

FWIW, even if Use Dfn Panels were to disable this, I'd rather continue to duplicate it in default-RD for ease of comparison between that and default.

@andreubotella andreubotella force-pushed the whatwg-style-dfn-panel branch 2 times, most recently from 25b5a18 to de23afd Compare September 29, 2020 13:26
Andreu Botella added 2 commits September 29, 2020 16:10
Turn off style-dfn-panel for WHATWG
8f9aa15 
See whatwg/whatwg.org#343, which moves those styles into WHATWG's
standard.css stylesheet.
Change defaults-RD.include as well
dc3a449
andreubotella pushed a commit to andreubotella/whatwg.org that referenced this pull request Oct 1, 2020
Add Bikeshed's style-dfn-panels styles to standard.css
46bf931 
This change additionally modifies a few rules from Bikeshed's styles for
integration with the dfn panels in the HTML spec.

See speced/bikeshed#1772, which turns off Bikeshed's style-dfn-panels
styles, and whatwg/html#5947, which modifies HTML's html-dfn.js script
to work with these styles.
@andreubotella andreubotella mentioned this pull request Oct 1, 2020
Merged
domenic pushed a commit to whatwg/whatwg.org that referenced this pull request Oct 2, 2020
@domenic
Add Bikeshed's style-dfn-panels styles to standard.css
b02ad9a 
This change additionally modifies a few rules from Bikeshed's styles for
integration with the dfn panels in the HTML spec.

See speced/bikeshed#1772, which turns off Bikeshed's style-dfn-panels
styles, and whatwg/html#5947, which modifies HTML's html-dfn.js script
to work with these styles.
@domenic domenic merged commit e492d58 into speced:master Oct 2, 2020
@andreubotella andreubotella deleted the whatwg-style-dfn-panel branch October 2, 2020 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andreubotella @tabatkins @annevk @domenic