Add Bikeshed's style-dfn-panels styles to standard.css #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreubotella
pushed a commit
to andreubotella/html
that referenced
this pull request
Sep 25, 2020
This change removes the HTML-specific styles dealing with the dfn panels, and changes html-dfn.js to have those panels match Bikeshed's output more closely. The particular changes are: - Panels have the "dfn-panel" class, rather than "dfnPanel". They also have the "on" class, to make them visible. - Dfn panels get created as children of body rather than of the dfn element, and their position is set when they are created. - Moved panels gain the "activated" class, instead of gaining inline styles. - The elements that can open a dfn panel when clicked now include headings with the "data-dfn-type" attribute (corresponding to a "dfn" attribute in the source), and every such element is populated with the "dfn-paneled" class when the script first runs. - Removes the "dfnEnabled" class from body. See whatwg/whatwg.org#343, which adds Bikeshed's dfn panel styles to standard.css.
andreubotella
pushed a commit
to andreubotella/html
that referenced
this pull request
Sep 25, 2020
This change removes the HTML-specific styles dealing with the dfn panels, and changes html-dfn.js to have those panels match Bikeshed's output more closely. The particular changes are: - Panels have the "dfn-panel" class, rather than "dfnPanel". They also have the "on" class, to make them visible. - Dfn panels get created as children of body rather than of the dfn element, and their position is set when they are created. - Moved panels gain the "activated" class, instead of gaining inline styles. - The elements that can open a dfn panel when clicked now include headings with the "data-dfn-type" attribute (corresponding to a "dfn" attribute in the source), and every such element is populated with the "dfn-paneled" class when the script first runs. - Removes the "dfnEnabled" class from body. See whatwg/whatwg.org#343, which adds Bikeshed's dfn panel styles to standard.css.
This was referenced Sep 25, 2020
|
Thanks for working on this. Can we merge this without merging the HTML change or will HTML be badly impacted if we do that? |
Merging this before the HTML change is fine, since the HTML panels use different classes than Bikeshed's (Bikeshed's However, since @sideshowbarker has raised concerns in whatwg/html#5947 about the way I've changed the way the dfn panels are positioned in the HTML spec, it's probably best to wait until that's resolved, so the styles can be adjusted. |
andreubotella
pushed a commit
to andreubotella/bikeshed
that referenced
this pull request
Sep 29, 2020
See whatwg/whatwg.org#343, which moves those styles into WHATWG's standard.css stylesheet.
andreubotella
pushed a commit
to andreubotella/bikeshed
that referenced
this pull request
Sep 29, 2020
See whatwg/whatwg.org#343, which moves those styles into WHATWG's standard.css stylesheet.
domenic
approved these changes
Oct 1, 2020
There was a problem hiding this comment.
LGTM, and seems to address @sideshowbarker's comments earlier. Happy to merge as soon as you confirm that it's all good to merge.
| The dfn-paneled class is specific to Bikeshed, while dfnEnabled | ||
| identifies builds of the HTML spec that support dfn panels. */ | ||
| .dfn-paneled, | ||
| body.dfnEnabled dfn, |
There was a problem hiding this comment.
I guess we probably can't use :is() yet, sigh.
andreubotella
pushed a commit
to andreubotella/html
that referenced
this pull request
Oct 1, 2020
This change removes the HTML-specific styles dealing with the dfn panels, and changes html-dfn.js to have those panels match Bikeshed's output more closely. The particular changes are: - Panels have the "dfn-panel" class, rather than "dfnPanel". They also have the "on" class, to make them visible. - Moved panels gain the "activated" class, instead of gaining inline styles. - The elements that can open a dfn panel when clicked now include headings with the "data-dfn-type" attribute (corresponding to a "dfn" attribute in the source). See whatwg/whatwg.org#343, which adds Bikeshed's dfn panel styles to standard.css.
This change additionally modifies a few rules from Bikeshed's styles for integration with the dfn panels in the HTML spec. See speced/bikeshed#1772, which turns off Bikeshed's style-dfn-panels styles, and whatwg/html#5947, which modifies HTML's html-dfn.js script to work with these styles.
andreubotella
force-pushed
the
dfn-panel-styles
branch
from
b0da1b8 to
46bf931
Compare
sideshowbarker
approved these changes
Oct 2, 2020
domenic
pushed a commit
to speced/bikeshed
that referenced
this pull request
Oct 2, 2020
See whatwg/whatwg.org#343, which moves those styles into WHATWG's standard.css stylesheet.
domenic
pushed a commit
to whatwg/html
that referenced
this pull request
Oct 2, 2020
This change removes the HTML-specific styles dealing with the dfn panels, and changes html-dfn.js to have those panels match Bikeshed's output more closely. The particular changes are: - Panels have the "dfn-panel" class, rather than "dfnPanel". They also have the "on" class, to make them visible. - Moved panels gain the "activated" class, instead of gaining inline styles. - The elements that can open a dfn panel when clicked now include headings with the "data-dfn-type" attribute (corresponding to a "dfn" attribute in the source). See whatwg/whatwg.org#343, which adds Bikeshed's dfn panel styles to standard.css.
mfreed7
pushed a commit
to mfreed7/html
that referenced
this pull request
Oct 2, 2020
This change removes the HTML-specific styles dealing with the dfn panels, and changes html-dfn.js to have those panels match Bikeshed's output more closely. The particular changes are: - Panels have the "dfn-panel" class, rather than "dfnPanel". They also have the "on" class, to make them visible. - Moved panels gain the "activated" class, instead of gaining inline styles. - The elements that can open a dfn panel when clicked now include headings with the "data-dfn-type" attribute (corresponding to a "dfn" attribute in the source). See whatwg/whatwg.org#343, which adds Bikeshed's dfn panel styles to standard.css.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change additionally modifies a few rules from Bikeshed's styles for integration with the dfn panels in the HTML spec.
See speced/bikeshed#1772, which turns off Bikeshed's
style-dfn-panelsstyles, and whatwg/html#5947, which modifies HTML'shtml-dfn.jsscript to work with these styles.