Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sphinx 8.2.0: Tests broken when using sphinx.testsing.path #13377

Closed
attakei opened this issue Feb 21, 2025 · 0 comments · Fixed by #13378
Closed

Sphinx 8.2.0: Tests broken when using sphinx.testsing.path #13377

attakei opened this issue Feb 21, 2025 · 0 comments · Fixed by #13378

Comments

@attakei
Copy link
Contributor

attakei commented Feb 21, 2025

Describe the bug

Hi, I develop Sphinx extension (e.g. sphinx-revealjs).

When I run tests using sphinx.testing.path for rootdir of fixtures with Sphinx 8.2.0,
all tests raise error unexpected timing.

Expected

Dsiplay RemovedInSphinx90Warning, but test passes.

Actually

All tests fail with AttributeError: 'path' object has no attribute 'is_dir'.

Comment

All tests of Sphinx are written expected that uses pathlib.Path for path-type object and sphinx.testing.fixtures does not care possibility cases using sphinx.testing.path.

It should keep compatibily before release Sphinx 9.x because sphinx.testing.path is but marked deprecated and not removed.

How to Reproduce

I created GitHub repo for reproduction.

git clone http://github.com/attakei-sandbox/sphinx-issue-demo
cd sphinx-issue-demo
pip install .
pytest

Environment Information

Platform:              linux; (Linux-6.13.1-arch2-1-x86_64-with-glibc2.41)
Python version:        3.11.11 (main, Feb 12 2025, 14:51:05) [Clang 19.1.6 ])
Python implementation: CPython
Sphinx version:        8.2.0
Docutils version:      0.21.2
Jinja2 version:        3.1.5
Pygments version:      2.19.1

Sphinx extensions

No extensions (this report is for `sphinx.testing`)

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants