Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sphinx.testing.fixtures still also works when type of rootdir is sphinx.testing.path #13378

Merged
merged 6 commits into from
Feb 21, 2025

Conversation

attakei
Copy link
Contributor

@attakei attakei commented Feb 21, 2025

Purpose

This is patch commit until release ver 9.x will remove sphinx.testing.path.

This PR will not have side-effect for currently tests (any test in this repo uses pathlib.Path).

References

@attakei attakei changed the title sphinx.testing.fixtures also works when type of rootdir is `sphin… sphinx.testing.fixtures still also works when type of rootdir is sphinx.testing.path. Feb 21, 2025
@attakei attakei changed the title sphinx.testing.fixtures still also works when type of rootdir is sphinx.testing.path. sphinx.testing.fixtures still also works when type of rootdir is sphinx.testing.path Feb 21, 2025
@attakei
Copy link
Contributor Author

attakei commented Feb 21, 2025

There are workflow result for patch in reproduction repo.

Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

A

@AA-Turner AA-Turner merged commit 7e1bf28 into sphinx-doc:master Feb 21, 2025
23 checks passed
@AA-Turner AA-Turner added this to the 8.2.x milestone Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sphinx 8.2.0: Tests broken when using sphinx.testsing.path
2 participants