Keep track of num failed tasks for a worker. #1543
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@erikbern Any idea what is up with the builds? Doesn't seem to be a code issue. Last two builds have error-ed because of this: https://travis-ci.org/spotify/luigi/jobs/108323647 |
|
@erikbern My hunch is that it is impacting the performance of that test case since it is called |
|
@erikbern bump? |
|
any reason this was closed? i guess it's been sitting here for a long time, not sure why |
|
After a quick glance of the code I don't understand it. It just threads along the variable but it never seems to print or use it for anything. Anyway still looks interesting. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add bookkeeping for number of failed tasks when getting work from the scheduler and workers.