-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OpenerTarget Support. #1555
Add OpenerTarget Support. #1555
Conversation
Allow a single luigi target to open multiple file system types. This can allow for easier local testing, unit test, and greater flexability of your luigi tasks.
Note this is fixed if you edit Maybe a config was changed, or the sphinx version isn't pinned and it had a breaking change added? |
memory. | ||
|
||
example: | ||
* mock://foo/bar.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor thing but shouldn't it be just "mock:foo/bar.txt"? double slash usually indicates a hostname
not blocking
I set it up to use a URI-like syntax (inspired by the syntax of http://commons.apache.org/vfs/filesystems.html). |
that's great – thanks for making sure we adhere to standards! |
@sisidra didn't Spotify want something like this once? @KyleJamesWalker, out of curiosity, are you still using this module. Is everything working out good? |
@Tarrasch not sure. We are in JVM land and Luigi is only orchestration layer. Anyway thanks for pinging ;) |
I think luigi only for orchestration is the case for many luigi players these days. I also don't use luigi MR today based on my experience from Spotify. Anyway I thought Spotify previously had migration issues when it came to HDFS --> GFS migration. And that this Opener factory could smooth things. :) |
Allow a single luigi target to open multiple file system types. This can allow for easier local testing, unit test, and greater flexibility of your luigi tasks.
Example:
I've only add three target types so far to make sure this pattern is accepted into the code base (and this is all I needed to run our pipeline in all environments needed).