Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: using default_scheduler_url as a mounting point for not root path #3214

Closed
wants to merge 3 commits into from
Closed

Conversation

franckOL
Copy link
Contributor

@franckOL franckOL commented Dec 13, 2022

(http://address/mount) behind proxy works. fix #3213

Signed-off-by: ROUDET Franck INNOV/IT-S [email protected]

Description

2 files modified to change the build of URL.
api path not at root now, it is in fact the same strategy that use the GUI.

Motivation and Context

Fixes:

Have you tested this? If so, how?

I'm able to test:

  • With or Without scheduler-url set
  • With or Without scheduler-url not at root

(http://address/mount) behind proxy works. fix #3213

Signed-off-by: ROUDET Franck INNOV/IT-S <[email protected]>
@franckOL franckOL requested review from dlstadther and a team as code owners December 13, 2022 11:48
@franckOL
Copy link
Contributor Author

I don't know how to test with tox.
I test locally GUI and API both with mounting point and at root.

@franckOL
Copy link
Contributor Author

franckOL commented Jan 2, 2023

@dlstadther What do you think about that PR ?

@dlstadther
Copy link
Collaborator

@franckOL , you'll need to look into and fix any failing tests as a result of this change.

@franckOL
Copy link
Contributor Author

franckOL commented Jan 2, 2023

Not seeing how to fix codeconv. I think my changes are not visible in codecov.
and for failed @github-actions Build / core (3.9, py39-core) (pull_request), Not understanding what happens ! network issue :-)

@franckOL franckOL closed this by deleting the head repository Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

using default_scheduler_url as a mounting point (not root http://address/mount) behind proxy not working
2 participants