Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: using default_scheduler_url as a mounting point for not root path #3214

Closed
wants to merge 3 commits into from
Closed

fix: using default_scheduler_url as a mounting point for not root path #3214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef3c7fd
fix: using default_scheduler_url as a mounting point for not root path
franckOL Dec 13, 2022
dda660d
Merge branch 'master' into master
franckOL Jan 2, 2023
c078d36
Fix test issue. force base url to end with /
franckOL Jan 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion luigi/rpc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ def __init__(self, url='http://localhost:8082/', connect_timeout=None):
'You need to install requests-unixsocket for Unix socket support.'
)

self._url = url.rstrip('/')
self._url = url if url[-1] == '/' else url + '/'
config = configuration.get_config()

if connect_timeout is None:
Expand Down
2 changes: 1 addition & 1 deletion luigi/scheduler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ def rpc_func(self, *args, **kwargs):
if not all(arg in actual_args for arg in required_args):
raise TypeError('{} takes {} arguments ({} given)'.format(
fn_name, len(all_args), len(actual_args)))
return self._request('/api/{}'.format(fn_name), actual_args, **request_args)
return self._request('api/{}'.format(fn_name), actual_args, **request_args)

RPC_METHODS[fn_name] = rpc_func
return fn
Expand Down