AddressResolver with DNS or List?

[lmx1989219]

hi,
i found the addresses conf with spring.rabbitmq.addresses=192.168.103.34:5672,192.168.73.129:5672 is not well,because it fixed target rabbitmq server node rather than random a node.
and i could not want to use DnsRecordIpAddressResolver.because it has higher costs.

following code if not set to false,i think more well.because the connect is random

	public RabbitConnectionFactoryBean() {
		this.connectionFactory.setAutomaticRecoveryEnabled(false);
	}

 if (isAutomaticRecoveryEnabled()) {
            // see com.rabbitmq.client.impl.recovery.RecoveryAwareAMQConnectionFactory#newConnection
            AutorecoveringConnection conn = new AutorecoveringConnection(params, fhFactory, addressResolver, metricsCollector);

            conn.init();
            return conn;
        } else {
            List<Address> addrs = addressResolver.getAddresses();
            Exception lastException = null;
            for (Address addr : addrs) {
                try {
                    FrameHandler handler = fhFactory.create(addr);
                    AMQConnection conn = createConnection(params, handler, metricsCollector);
                    conn.start();
                    this.metricsCollector.newConnection(conn);
                    return conn;
                } catch (IOException e) {
                    lastException = e;
                } catch (TimeoutException te) {
                    lastException = te;
                }
            }

[lmx1989219]

random a address

public RecoveryAwareAMQConnection newConnection() throws IOException, TimeoutException {
        Exception lastException = null;
        List<Address> shuffled = shuffle(addressResolver.getAddresses());

        for (Address addr : shuffled) {
            try {
                FrameHandler frameHandler = factory.create(addr);
                RecoveryAwareAMQConnection conn = createConnection(params, frameHandler, metricsCollector);
                conn.start();
                metricsCollector.newConnection(conn);

[garyrussell]

this.connectionFactory.setAutomaticRecoveryEnabled(false);

Spring AMQP has its own connection recovery mechanism; it existed before the rabbitmq client added connection recovery.

It is best not to use the client recovery; there have been problems with the two mechanisms adversely interacting in the past (hung consumers); we have fixed all known problems, but it's safer to simply turn off the client's recovery mechanism.

The shuffle is interesting; we can add a similar mechanism to this framework.

[lmx1989219]

thank you @garyrussell