Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-1029: Add option to randomize connection order #1030

Merged
merged 1 commit into from
Jun 20, 2019

Conversation

garyrussell
Copy link
Contributor

@garyrussell garyrussell commented Jun 20, 2019

Resolves #1029

Add shuffleAddresses to the CachingConnectionFactory.

cherry-pick to 2.1.x

Copy link
Member

@artembilan artembilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gary, LGTM, unless you are going to do something else with Travis and its Java problem.

.travis.yml Outdated
@@ -1,6 +1,5 @@
language: java
jdk: oraclejdk8
sudo: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't help 😢

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah - reverted - I was just comparing with kafka and this seemed like the only difference.

@artembilan
Copy link
Member

Please, resolve conflict in the whats-new.adoc and I'll merge.

Thanks

Resolves spring-projects#1029

Add `shuffleAddresses` to the `CachingConnectionFactory`.
@artembilan artembilan merged commit 6cf3211 into spring-projects:master Jun 20, 2019
@artembilan
Copy link
Member

... and cherry-picked to 2.1.x as f1541f4

@garyrussell garyrussell deleted the GH-1029 branch June 21, 2019 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AddressResolver with DNS or List?
2 participants