Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an enum to select the type of publisher confirms #1067

Closed
garyrussell opened this issue Aug 13, 2019 · 4 comments · Fixed by #1068 or #1070
Closed

Add an enum to select the type of publisher confirms #1067

garyrussell opened this issue Aug 13, 2019 · 4 comments · Fixed by #1068 or #1070
Assignees
@garyrussell
Milestone
2.2.RC1

Comments

@garyrussell
Copy link
Contributor

Simplify Boot auto-configuration.

SIMPLE and CORRELATED.

See spring-projects/spring-boot#17848 (comment)
@garyrussell garyrussell added this to the 2.2.RC1 milestone Aug 13, 2019
@garyrussell garyrussell self-assigned this Aug 13, 2019
@snicoll
Copy link
Member

snicoll commented Aug 13, 2019

Thanks Gary. If none is a valid value, we probably need an option in the enum for that as well.

@snicoll snicoll mentioned this issue Aug 13, 2019
Closed
@garyrussell
Copy link
Contributor Author

Good point!

garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Aug 13, 2019
@garyrussell
spring-projectsGH-1067: Add enum for publisher confirm type
e791e6e 
Resolves spring-projects#1067
@garyrussell garyrussell mentioned this issue Aug 13, 2019
Merged
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Aug 19, 2019
@garyrussell
spring-projectsGH-1067: Add enum for publisher confirm type
b8e36dd 
Resolves spring-projects#1067
artembilan pushed a commit that referenced this issue Aug 19, 2019
@garyrussell @artembilan
GH-1067: Add enum for publisher confirm type
acb5683 
Resolves #1067

* * Refactor deprecated setters to use new setter

* * Fix this.publisherConnectionFactory typo
artembilan added a commit to spring-projects/spring-integration that referenced this issue Aug 19, 2019
@artembilan
Fix AMQP CF publisher confirms type usage
503d001 
Related to spring-projects/spring-amqp#1067
@snicoll
Copy link
Member

snicoll commented Aug 20, 2019

Can we please reopen this issue? I think deprecated methods that take a boolean are ignoring the boolean value and set the enum to enable the feature. If you call those methods with false they'll actually enable the behaviour.

@garyrussell
Copy link
Contributor Author

Doh

@garyrussell garyrussell reopened this Aug 20, 2019
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Aug 20, 2019
@garyrussell
spring-projectsGH-1067: Fix deprecated setters
12197b3 
Fixes spring-projects#1067
@garyrussell garyrussell mentioned this issue Aug 20, 2019
Merged
artembilan pushed a commit that referenced this issue Aug 20, 2019
@garyrussell @artembilan
GH-1067: Fix deprecated setters
3d5fe16 
Fixes #1067

* * reset `confirmType` in setter, if appropriate

* * Fix reset propagation to publisher CF
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garyrussell garyrussell

Labels
None yet
Projects
None yet
Milestone
2.2.RC1
2 participants
@garyrussell @snicoll