Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-1067: Add enum for publisher confirm type #1068

Merged
merged 3 commits into from
Aug 19, 2019
Merged

GH-1067: Add enum for publisher confirm type #1068

merged 3 commits into from
Aug 19, 2019

Conversation

garyrussell
Copy link
Contributor

Resolves #1067

artembilan
artembilan requested changes Aug 15, 2019
View reviewed changes
Copy link
Member

@artembilan artembilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just only one concern.

...abbit/src/main/java/org/springframework/amqp/rabbit/connection/CachingConnectionFactory.java Show resolved Hide resolved
@artembilan
Copy link
Member

Gary, would you mind to take a look, please, into failure:

org.springframework.amqp.rabbit.AsyncRabbitTemplateTests > testConvertWithConfirm FAILED

    java.lang.IllegalStateException

        Caused by: org.springframework.beans.factory.BeanCreationException

            Caused by: org.springframework.beans.BeanInstantiationException

                Caused by: java.lang.NullPointerException

See Travis report. Sounds like some change in SF...

Thanks

@artembilan artembilan merged commit acb5683 into spring-projects:master Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artembilan artembilan artembilan requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an enum to select the type of publisher confirms
2 participants
@garyrussell @artembilan