Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing @Override annotation in GenericJackson2JsonRedisSerializer #3053

Closed
deeaitche opened this issue Nov 21, 2024 · 0 comments
Closed

Missing @Override annotation in GenericJackson2JsonRedisSerializer #3053

deeaitche opened this issue Nov 21, 2024 · 0 comments
Assignees
Labels
type: documentation A documentation update

Comments

@deeaitche
Copy link

*/
public boolean useForType(JavaType javaType) {
if (javaType.isJavaLangObject()) {
return true;
}
javaType = resolveArrayOrWrapper(javaType);
if (javaType.isEnumType() || ClassUtils.isPrimitiveOrWrapper(javaType.getRawClass())) {
return false;
}
if (javaType.isFinal() && !KotlinDetector.isKotlinType(javaType.getRawClass())
&& javaType.getRawClass().getPackageName().startsWith("java")) {
return false;
}
// [databind#88] Should not apply to JSON tree models:
return !TreeNode.class.isAssignableFrom(javaType.getRawClass());
}

This method is overridinguseForType(JavaType t) of com.fasterxml.jackson.databindObjectMapper.DefaultTypeResolverBuilder

@deeaitche deeaitche changed the title Missing @Override annotation in GenericJackson2JsonRedisSerializer Missing @Override annotation in GenericJackson2JsonRedisSerializer Nov 21, 2024
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 21, 2024
@mp911de mp911de self-assigned this Nov 25, 2024
@mp911de mp911de added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 25, 2024
@mp911de mp911de added this to the 3.3.8 (2024.0.8) milestone Jan 15, 2025
mp911de added a commit that referenced this issue Jan 15, 2025
Add missing Nullable annotations to serializers.

See #3053
Original pull request: #3058
mp911de pushed a commit that referenced this issue Jan 15, 2025
…izer.useForType`.

This fixes an issue where the `useForType` method in
GenericJackson2JsonRedisSerializer did not have the `@Override`
annotation, making it less clear that it overrides a method
from DefaultTypeResolverBuilder.

Closes #3053
Original pull request: #3058
mp911de added a commit that referenced this issue Jan 15, 2025
Add missing Nullable annotations to serializers.

See #3053
Original pull request: #3058
mp911de pushed a commit that referenced this issue Jan 15, 2025
…izer.useForType`.

This fixes an issue where the `useForType` method in
GenericJackson2JsonRedisSerializer did not have the `@Override`
annotation, making it less clear that it overrides a method
from DefaultTypeResolverBuilder.

Closes #3053
Original pull request: #3058
mp911de added a commit that referenced this issue Jan 15, 2025
Add missing Nullable annotations to serializers.

See #3053
Original pull request: #3058
mp911de pushed a commit that referenced this issue Jan 15, 2025
…izer.useForType`.

This fixes an issue where the `useForType` method in
GenericJackson2JsonRedisSerializer did not have the `@Override`
annotation, making it less clear that it overrides a method
from DefaultTypeResolverBuilder.

Closes #3053
Original pull request: #3058
mp911de added a commit that referenced this issue Jan 15, 2025
Add missing Nullable annotations to serializers.

See #3053
Original pull request: #3058
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
3 participants