Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing @Override annotation to useForType in GenericJackson2JsonRedisSerializer #3058

Closed
wants to merge 1 commit into from
Closed

Add missing @Override annotation to useForType in GenericJackson2JsonRedisSerializer #3058

wants to merge 1 commit into from

Conversation

kimjinmyeong
Copy link
Contributor

@kimjinmyeong kimjinmyeong commented Nov 26, 2024 •
edited
Loading

The useForType method in GenericJackson2JsonRedisSerializer overrides DefaultTypeResolverBuilder.useForType but was missing the @Override annotation.
so I added @Override to useForType in GenericJackson2JsonRedisSerializer.

(Since this is a minor change that only adds an annotation, I did not add myself as an author in the class header... but, if it is considered necessary, I am happy to update the PR.)

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@kimjinmyeong
Fix: Add missing @OverRide annotation to useForType
0881363 
This fixes an issue where the `useForType` method in
GenericJackson2JsonRedisSerializer did not have the `@Override`
annotation, making it less clear that it overrides a method
from DefaultTypeResolverBuilder.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 26, 2024
@kimjinmyeong kimjinmyeong changed the title Fix: Add missing @Override annotation to useForType in GenericJackson2JsonRedisSerializer Add missing @Override annotation to useForType in GenericJackson2JsonRedisSerializer Nov 26, 2024
@kimjinmyeong kimjinmyeong changed the title Add missing @Override annotation to useForType in GenericJackson2JsonRedisSerializer Add missing @Override annotation to useForType in GenericJackson2JsonRedisSerializer Nov 26, 2024
@mp911de mp911de self-assigned this Dec 2, 2024
@mp911de mp911de added type: bug A general bug type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged type: bug A general bug labels Jan 15, 2025
@mp911de mp911de added this to the 3.3.8 (2024.0.8) milestone Jan 15, 2025
mp911de pushed a commit that referenced this pull request Jan 15, 2025
@kimjinmyeong @mp911de
Add missing @Override annotation to `GenericJackson2JsonRedisSerial…
6f399ab 
…izer.useForType`.

This fixes an issue where the `useForType` method in
GenericJackson2JsonRedisSerializer did not have the `@Override`
annotation, making it less clear that it overrides a method
from DefaultTypeResolverBuilder.

Closes #3053
Original pull request: #3058
mp911de added a commit that referenced this pull request Jan 15, 2025
@mp911de
Polishing.
ce2c7ca 
Add missing Nullable annotations to serializers.

See #3053
Original pull request: #3058
mp911de pushed a commit that referenced this pull request Jan 15, 2025
@kimjinmyeong @mp911de
Add missing @Override annotation to `GenericJackson2JsonRedisSerial…
5166f4c 
…izer.useForType`.

This fixes an issue where the `useForType` method in
GenericJackson2JsonRedisSerializer did not have the `@Override`
annotation, making it less clear that it overrides a method
from DefaultTypeResolverBuilder.

Closes #3053
Original pull request: #3058
mp911de added a commit that referenced this pull request Jan 15, 2025
@mp911de
Polishing.
7645411 
Add missing Nullable annotations to serializers.

See #3053
Original pull request: #3058
mp911de pushed a commit that referenced this pull request Jan 15, 2025
@kimjinmyeong @mp911de
Add missing @Override annotation to `GenericJackson2JsonRedisSerial…
d75df92 
…izer.useForType`.

This fixes an issue where the `useForType` method in
GenericJackson2JsonRedisSerializer did not have the `@Override`
annotation, making it less clear that it overrides a method
from DefaultTypeResolverBuilder.

Closes #3053
Original pull request: #3058
mp911de added a commit that referenced this pull request Jan 15, 2025
@mp911de
Polishing.
2cf57db 
Add missing Nullable annotations to serializers.

See #3053
Original pull request: #3058
mp911de pushed a commit that referenced this pull request Jan 15, 2025
@kimjinmyeong @mp911de
Add missing @Override annotation to `GenericJackson2JsonRedisSerial…
525f9b6 
…izer.useForType`.

This fixes an issue where the `useForType` method in
GenericJackson2JsonRedisSerializer did not have the `@Override`
annotation, making it less clear that it overrides a method
from DefaultTypeResolverBuilder.

Closes #3053
Original pull request: #3058
mp911de added a commit that referenced this pull request Jan 15, 2025
@mp911de
Polishing.
020e5b6 
Add missing Nullable annotations to serializers.

See #3053
Original pull request: #3058
@mp911de
Copy link
Member

mp911de commented Jan 15, 2025

Thank you for your contribution. That's merged, polished, and backported now.

@mp911de mp911de closed this Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mp911de mp911de

Labels
type: documentation A documentation update
Projects
None yet
Milestone
3.3.8 (2024.0.8)
Development

Successfully merging this pull request may close these issues.

Missing @Override annotation in GenericJackson2JsonRedisSerializer
3 participants
@kimjinmyeong @mp911de @spring-projects-issues