Skip to content
This repository has been archived by the owner on Sep 11, 2020. It is now read-only.

plumbing: object, fix Commit.Verify test #656

Merged
merged 1 commit into from
Nov 24, 2017

Conversation

darkowlzz
Copy link
Contributor

@darkowlzz darkowlzz commented Nov 24, 2017

Commit verification test seems to be passing on my computer still, even on master. This PR is for debugging the failure in Travis.

@darkowlzz
Copy link
Contributor Author

darkowlzz commented Nov 24, 2017

I see the difference in the commit timezone.

author Sunny <[email protected]> 1511197315 +0000
committer Sunny <[email protected]> 1511197315 +0000

Since I used time.Unix(), it generated the time in relation to local time of the machine, which is different for travis machines from what the signed commit had.

Test was failing because of the relative time zone attached to the commit.
Adding a fixed location to the time fixes the issue.
@darkowlzz darkowlzz changed the title Debug commit verify failure test: plumbing/object fix Commit.Verify test Nov 24, 2017
@darkowlzz
Copy link
Contributor Author

Test was failing because of the relative time zone attached to the commit.
Adding a fixed location to the time fixes the issue.

@mcuadros mcuadros changed the title test: plumbing/object fix Commit.Verify test plumbing: object, fix Commit.Verify test Nov 24, 2017
@mcuadros mcuadros merged commit a83486f into src-d:master Nov 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants