Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable IO in siteOutput #124

Merged
merged 1 commit into from
Aug 2, 2022
Merged

Enable IO in siteOutput #124

merged 1 commit into from
Aug 2, 2022

Conversation

srid
Copy link
Owner

@srid srid commented Aug 1, 2022

I see a need for this in srid/emanote#327 (building search index on-demand)

I'm not alone; resolves #64

@srid srid changed the base branch from master to multisite August 1, 2022 20:58
@srid
Copy link
Owner Author

srid commented Aug 1, 2022

In most cases, however, siteOutput shouldn't need IO (since all IO actions are generally abstracted out in siteInput when building the model). This should be documented clearly; it is generally better to relegate impure stuff in siteInput, keeping siteOutput as pure as possible - since siteOutput is called when serving the live server requests.

@srid srid merged commit 7bb276f into multisite Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow exceptions and logging in render function
1 participant
@srid