-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full-text-search via Stork #327
Conversation
One thing to consider here is that this has a lot of impact on how Emanote sites are used, and I predict they will also have a great impact on how they are written as well. On the negative side, this search feature could:
This isn't just an added positive feature, it also dulls down the other features of Emanote. On the other hand, the positives are things like:
Do we want to counteract the negatives somehow? Or document the pros/cons of using search vs tags & uplink trees? This could actually be a "killer feature" that makes users jump to writing docs in Emanote instead of Hugo or Jekyll. Most programs are after all only as strong as their search feature.
|
Note to self: in addition to the UI changes in this PR, stork index generation should be done in postRun.
We want to use emanote's model internally rather than parsing HTML files. Also add |
@jilleJr Thanks! I'll hook the rest of the machinery up, and see if we can have |
Thank you so much! I can create docs for this later (after this PR is merged, when Emanote's behavior on this is decided) |
4462921
to
a6c915d
Compare
Latest changes:
Demo of neuron-like note layout with search box: https://jillejr.github.io/emanote/demo/neuron-layout.html |
On second thought, this is now how I envision to enable search, where it's a 2-step process:
|
We just add a route for Stork index, and let Haskell build it behind the scenes. Performance and correctness is 100% yet.
@jilleJr Give 12cf3a1 a try. The stork index is built behind the scenes in both live server and generate mode. Note to self:
|
Thank you, @jilleJr, for checking up my project. This seems, thus, to be an issue on Intel Macs. I shall see on M1 (may be only in a few days). UTF-8 is default for Mac, thus I had no "invalid characters", and missing links will disappear when I end moving the project from OpenProject to markdown/Obsidian/Emanote. I shall let you know once compile Emanote on a M1 Mac. |
This is though a sample size of 1, which means there are a lot more variables at play here. I know some coworkers has Macs, maybe intel ones. I'll ask if any of them are willing to test this out as well. |
I suppose the issue is about Intel Macs because I have an extremely limited installation of Nix, only Emanote in it, and I have very little set in respect of variables etc. But we shall see. Thank you once more! |
@Bipodos I tried https://github.com/Bipodos/Plotinus on my M1 mac, but under rosetta emulation (passing |
Note: if anybody wants to test this feature, run the following after cd'ing to your notebook:
|
Very basic intro. Could be expanded.
> @Bipodos I tried https://github.com/Bipodos/Plotinus on my M1 mac, but under rosetta emulation (passing `--option system x86_64-linux` to nix) - and I cannot reproduce your issue.
>
>
After having updated nix, the stork search now works on my Intel Mac. |
@srid Thank you for applying the changes! |
- Add a new route to serve the stork index (`-/stork.st`) - Build it as part of serving the route, so supported on live server and static search - Use stork from nix.
Closes #324
Tasks
[ ] srid: Handle concurrent reads of(live server is not production friendly)/-/stork.st
Changes
/-/stork.st
in live- and statically generated site by runningstork build
Preview
Demo: https://jillejr.github.io/emanote/
I even did the blurred backdrop thing from tailwindcss' website :P
For the narrow layout it's using only the 🔍 emoji when the sidebar is collapsed.
I was not really sure what to do with the neuron-like page, it currently steals a lot of the vertical view-space:
I used that published GitHub Pages to do some manual testing on my phone.
In a separate branch I made small changes to build the index in the CI pipeline and publish it to that above GitHub Pages site.