🔧 Fix variable extraction to always run #1500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidreneuw
requested review from
ErikApption,
Sean-Stilwell and
gcnabeel
as code owners
ErikApption
previously approved these changes
Dec 9, 2024
gcnabeel
approved these changes
Dec 10, 2024
ErikApption
added a commit
that referenced
this pull request
Jan 13, 2025
* added subscription to delete script (#1496) * added subscription to delete script * fixed the subscription id * Docker file for python function (#1497) * updated requirements with star patterns * added docker file, updated scripts to run on linux * fixed exec syntax * fixed typo in EnvName variable * added recommended no cache dir --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Fixing the non-functional copy users button * - added caching to doc ids - added check when docs are already loaded * 🔧 Fix variable extraction to always run (#1500) * Fix variable extraction to always run * Change it to extract variables on any status, not just create requested * Extract redundant code * Revert config change * Health check updates: Storage and webapp checks; monitoring page (#1502) * Web app health check WIP * Updated static class and cleaned up duplicate code * Updated storage and web app health checks * Infrastructure health page code improvements * update branch rules (#1505) * Hotfix for health check function (#1507) * Updated static class and cleaned up duplicate code * Infrastructure health page code improvements * Added missing dependency to let the function run * Rollback localizer workaround (#1506) * Restore original functionalioty, removing workaround. * reverted english localization * roll back french language workaround * fixed linting --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Nb/autodelete (#1509) * move delete logic to a service * update deletion page to use service --------- Co-authored-by: Erik <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update codeql.yml (#1510) * Update codeql.yml Update to force CodeQL to run when Auto Update PRs runs * fixed formatting/linting * Various cost usage improvements (#1503) * Various cost usage improvements * Handle mysterious "Missing" resource group values --------- Co-authored-by: Erik <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Fix code scanning alert no. 14: Log entries created from user input (#1512) * Fix code scanning alert no. 14: Log entries created from user input Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> * removed legacy file sharing controller * more cleanup. Removed other legacy components and services --------- Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Co-authored-by: Erik <[email protected]> * Health check function unit tests (#1511) * Web app health check WIP * Updated static class and cleaned up duplicate code * Updated storage and web app health checks * Infrastructure health page code improvements * Added missing dependency to let the function run * Health check unit tests WIP * Database and webapp health check unit tests * Added some checks; minor cleanup --------- Co-authored-by: Erik <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Adding login date/time (#1498) * Moving over from previous branch * Small changes to text * Tiny miniscule changes * Formatting * Making David's changes * implementing FakePortalTelemetryService --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Auto update v2 (#1515) * Update codeql * Update autorenew-pr * Create test.md * Update refresh-stale-prs.yml * Added exemption for PR Updater * add dockerfile for python function app for user sync (#1519) * init dockerize py func for user sync * improve pip command * Create docker-image.yml * Update docker-image.yml * Update docker-image.yml (#1522) * Skip not working test. Seems to be doing an external call (#1526) * Update refresh-stale-prs.yml Update Refresher * Updated Sort * Update SEARCH_API_URL for geo.ca (#1527) * Add appropriate header in startup.cs (#1525) Co-authored-by: datahub-portal-pr-rw[bot] <192352896+datahub-portal-pr-rw[bot]@users.noreply.github.com> * Allow Workspace Leads to Delete Workspaces (#1523) * permitted workspace leads to delete workspaces * added auth on actual delete page --------- Co-authored-by: datahub-portal-pr-rw[bot] <192352896+datahub-portal-pr-rw[bot]@users.noreply.github.com> * Remove navigation (#1530) * Overbudget UI updates and Function update (#1516) * UI changes for over budget workspaces * Cleaned localizer text * updated warning message * updated localization to match test --------- Co-authored-by: datahub-portal-pr-rw[bot] <192352896+datahub-portal-pr-rw[bot]@users.noreply.github.com> Co-authored-by: Erik <[email protected]> * 🔧 Adding a component for environment-specific content (#1531) * Adding new FSDH Environment component * Wrapping workspace creation page in FSDHEnvironment component, displaying message on prod * Wrapping registration page in FSDHEnvironment component * Fix important accessibility requirements (#1529) Co-authored-by: datahub-portal-pr-rw[bot] <192352896+datahub-portal-pr-rw[bot]@users.noreply.github.com> --------- Co-authored-by: gcnabeel <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Sean-Stilwell <[email protected]> Co-authored-by: David René <[email protected]> Co-authored-by: akhavich <[email protected]> Co-authored-by: John Bain <[email protected]> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Co-authored-by: shudsky <[email protected]> Co-authored-by: Simon Wang <[email protected]> Co-authored-by: Bo Lu <[email protected]> Co-authored-by: datahub-portal-pr-rw[bot] <192352896+datahub-portal-pr-rw[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
In a recent change, variable extraction was put behind an if statement of CreateRequested status, which made it never run except during workspace creation. Moved it to appropriately run.
Related Issues
Changes
Testing
Checklist