Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Health check updates: Storage and webapp checks; monitoring page #1502

Merged
merged 6 commits into from
Dec 10, 2024
Merged

Health check updates: Storage and webapp checks; monitoring page #1502

merged 6 commits into from
Dec 10, 2024

Conversation

akhavich
Copy link
Contributor

Pull Request

Description

This updates the storage and web app health checks to make them more representative. It also updates the health check monitoring pages, both under FSDH admin settings and per workspace, to exclude health checks for resources that have not been requested (for now, only storage and web app) and clean up a lot of dead code.

Related Issues

Task 9668 - Hide health checks for unrequested resources
Bug 8410 - Web app and storage health checks are not accurate
Task 8478 - Web App health check reports error when working

Changes

  • Storage and web app health checks: If the resources are not requested, set health status to "undefined"
  • Exclude "undefined" health status from being displayed in health check page
  • More comprehensive checking of storage account
  • Update webapp health check to use the app service status instead of trying to connect to the web app url, may not have always worked due to network restrictions
  • Minor code reorg: Renamed static class from "Service" to "Util" and removed from service initialization
  • Optimized display of stale (24h to 72h old) and expired (> 72h) health checks
  • Simplified data loading in infrastructure health page
  • Cleaned up unused code in infrastructure health page

Testing

  • Manually tested web app and storage health checks
  • Tested workspace health check page and the filterable table in infrastructure health page

Checklist

  • Code follows dotnet coding standards
  • Tests added/updated to cover changes

@ErikApption ErikApption merged commit d059c70 into develop Dec 10, 2024
34 checks passed
@ErikApption ErikApption deleted the ak/webapp_healthcheck branch December 10, 2024 20:00
ErikApption added a commit that referenced this pull request Jan 13, 2025
@ErikApption @gcnabeel
@github-actions @Sean-Stilwell @davidreneuw @akhavich @KingBain @github-advanced-security @shudsky @simon-wang-gc @bo-lu @datahub-portal-pr-rw
Release 4.0.8 (#1532)
06b9d52 
* added subscription to delete script (#1496)

* added subscription to delete script

* fixed the subscription id

* Docker file for python function (#1497)

* updated requirements with star patterns

* added docker file, updated scripts to run on linux

* fixed exec syntax

* fixed typo in EnvName variable

* added recommended no cache dir

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Fixing the non-functional copy users button

* - added caching to doc ids
- added check when docs are already loaded

* 🔧 Fix variable extraction to always run (#1500)

* Fix variable extraction to always run

* Change it to extract variables on any status, not just create requested

* Extract redundant code

* Revert config change

* Health check updates: Storage and webapp checks; monitoring page (#1502)

* Web app health check WIP

* Updated static class and cleaned up duplicate code

* Updated storage and web app health checks

* Infrastructure health page code improvements

* update branch rules (#1505)

* Hotfix for health check function (#1507)

* Updated static class and cleaned up duplicate code

* Infrastructure health page code improvements

* Added missing dependency to let the function run

* Rollback localizer workaround (#1506)

* Restore original functionalioty, removing workaround.

* reverted english localization

* roll back french language workaround

* fixed linting

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Nb/autodelete (#1509)

* move delete logic to a service

* update deletion page to use service

---------

Co-authored-by: Erik <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update codeql.yml (#1510)

* Update codeql.yml

Update to force CodeQL to run when Auto Update PRs runs

* fixed formatting/linting

* Various cost usage improvements (#1503)

* Various cost usage improvements

* Handle mysterious "Missing" resource group values

---------

Co-authored-by: Erik <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Fix code scanning alert no. 14: Log entries created from user input (#1512)

* Fix code scanning alert no. 14: Log entries created from user input

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

* removed legacy file sharing controller

* more cleanup. Removed other legacy components and services

---------

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: Erik <[email protected]>

* Health check function unit tests (#1511)

* Web app health check WIP

* Updated static class and cleaned up duplicate code

* Updated storage and web app health checks

* Infrastructure health page code improvements

* Added missing dependency to let the function run

* Health check unit tests WIP

* Database and webapp health check unit tests

* Added some checks; minor cleanup

---------

Co-authored-by: Erik <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Adding login date/time (#1498)

* Moving over from previous branch

* Small changes to text

* Tiny miniscule changes

* Formatting

* Making David's changes

* implementing FakePortalTelemetryService

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Auto update v2 (#1515)

* Update codeql
* Update autorenew-pr

* Create test.md

* Update refresh-stale-prs.yml

* Added exemption for PR Updater

* add dockerfile for python function app for user sync (#1519)

* init dockerize py func for user sync

* improve pip command

* Create docker-image.yml

* Update docker-image.yml

* Update docker-image.yml (#1522)

* Skip not working test. Seems to be doing an external call (#1526)

* Update refresh-stale-prs.yml

Update Refresher

* Updated Sort

* Update SEARCH_API_URL for geo.ca (#1527)

* Add appropriate header in startup.cs (#1525)

Co-authored-by: datahub-portal-pr-rw[bot] <192352896+datahub-portal-pr-rw[bot]@users.noreply.github.com>

* Allow Workspace Leads to Delete Workspaces (#1523)

* permitted workspace leads to delete workspaces

* added auth on actual delete page

---------

Co-authored-by: datahub-portal-pr-rw[bot] <192352896+datahub-portal-pr-rw[bot]@users.noreply.github.com>

* Remove navigation (#1530)

* Overbudget UI updates and Function update (#1516)

* UI changes for over budget workspaces

* Cleaned localizer text

* updated warning message

* updated localization to match test

---------

Co-authored-by: datahub-portal-pr-rw[bot] <192352896+datahub-portal-pr-rw[bot]@users.noreply.github.com>
Co-authored-by: Erik <[email protected]>

* 🔧 Adding a component for environment-specific content (#1531)

* Adding new FSDH Environment component

* Wrapping workspace creation page in FSDHEnvironment component, displaying message on prod

* Wrapping registration page in FSDHEnvironment component

* Fix important accessibility requirements (#1529)

Co-authored-by: datahub-portal-pr-rw[bot] <192352896+datahub-portal-pr-rw[bot]@users.noreply.github.com>

---------

Co-authored-by: gcnabeel <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Sean-Stilwell <[email protected]>
Co-authored-by: David René <[email protected]>
Co-authored-by: akhavich <[email protected]>
Co-authored-by: John Bain <[email protected]>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: shudsky <[email protected]>
Co-authored-by: Simon Wang <[email protected]>
Co-authored-by: Bo Lu <[email protected]>
Co-authored-by: datahub-portal-pr-rw[bot] <192352896+datahub-portal-pr-rw[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErikApption ErikApption ErikApption approved these changes

@Sean-Stilwell Sean-Stilwell Awaiting requested review from Sean-Stilwell Sean-Stilwell is a code owner

@davidreneuw davidreneuw Awaiting requested review from davidreneuw davidreneuw is a code owner

@gcnabeel gcnabeel Awaiting requested review from gcnabeel gcnabeel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akhavich @ErikApption