Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: sBTC token not SIP 10 compatible #1090

Closed
friedger opened this issue Dec 10, 2024 · 2 comments · Fixed by #1091
Closed

[Bug]: sBTC token not SIP 10 compatible #1090

friedger opened this issue Dec 10, 2024 · 2 comments · Fixed by #1091
Labels
bug Something isn't working clarity The clarity smart contracts.

Comments

@friedger
Copy link
Contributor

SIP-10 requires to print memos provided in the transfer function. The sBTC token contract does not print the memo.

See https://github.com/stacksgov/sips/blob/main/sips/sip-010/sip-010-fungible-token-standard.md#transfer

@friedger friedger added bug Something isn't working clarity The clarity smart contracts. labels Dec 10, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage in sBTC Dec 10, 2024
@setzeus
Copy link
Collaborator

setzeus commented Dec 10, 2024

Already added here: #1008

Just to confirm, does the print statement have to follow the format mentioned (using match) or is the following valid?

(print { topic: "transfer", amount: amount, sender: sender, recipient: recipient, memo: memo })

@friedger
Copy link
Contributor Author

The requirement is that the next event after ft transfer event is the memo.

@github-project-automation github-project-automation bot moved this from Needs Triage to Done in sBTC Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working clarity The clarity smart contracts.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants