Modular Clarity Update #1008
Merged
Modular Clarity Update #1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hstove
suggested changes
Dec 6, 2024
hstove
reviewed
Dec 6, 2024
setzeus
changed the title
hozzjss
reviewed
Dec 9, 2024
hozzjss
approved these changes
Dec 9, 2024
friedger
reviewed
Dec 9, 2024
friedger
previously requested changes
Dec 9, 2024
setzeus
force-pushed
the
clarity/modular
branch
from
a1dc60f to
5fe97c4
Compare
setzeus
force-pushed
the
clarity/modular
branch
3 times, most recently
from
9f35d4b to
a958230
Compare
|
@friedger can you please take another look here. |
setzeus
force-pushed
the
clarity/modular
branch
from
1de5f93 to
aa82f77
Compare
hstove
approved these changes
Dec 11, 2024
Was completed in an upstream branch! Dismissing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the proposed updates to the existing Clarity protocol in order to support protocol contract updates. This design is based off of the discussed items in #990.
Closes: #990
Changes
Explicitly tracks the 'active' version of the contracts for signers, deposits & withdrawals in the sbtc-registry. Additionally, validation is improved so that only the correct role for each contract type can write into the correct sbtc-registry functions.
Testing Information
Tests were updated accordingly & two new tests were added post-update with an example 'deposit-v1' contract.
Checklist: