Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sBTC] Make sBTC sip-10 compatible #1091

Merged
merged 2 commits into from
Dec 10, 2024
Merged

[sBTC] Make sBTC sip-10 compatible #1091

merged 2 commits into from
Dec 10, 2024

Conversation

friedger
Copy link
Contributor

Description

This PR adds a print statement to transfer function of sbtc token contract

Closes: #1090

Changes

Adds extract event to transfer of sBTC tokens

Testing Information

Unit test added.

Checklist:

  • I have performed a self-review of my code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@setzeus setzeus self-requested a review December 10, 2024 18:57
setzeus
setzeus approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@setzeus setzeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled & reviewed. Simple but critical bug fix for SIP10 compliance that adds a print statement: LGTM.

@setzeus setzeus merged commit d5558a3 into main Dec 10, 2024
4 checks passed
@moodmosaic moodmosaic mentioned this pull request Dec 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@setzeus setzeus setzeus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: sBTC token not SIP 10 compatible
2 participants
@friedger @setzeus