Vote for aggregated public key #4116

friedger · 2023-12-01T21:41:20Z

Description

This PR adds voting for the aggregated public key submitted by signers.

Applicable issues

fixes [Clarity] DKG vote registration #3968

Additional info (benefits, drawbacks, caveats)

Checklist

Test coverage for new or modified code paths
Changelog is updated
Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
New clarity functions have corresponding PR in clarity-benchmarking repo
New integration test(s) added to bitcoin-tests.yml

This commit addresses an issue where lease timings were not correctly adjusted for compatibility with epoch 2.4. The epoch 2.4 update introduced an extra block in the simnet start sequence, causing names to expire one block later than before. This fix ensures that lease timings align with the updated epoch requirements.

…ng-epoch-2.4 Argon: Pox 4 - Adjust Lease Timing for Epoch 2.4 Compatibility in BNS tests

…phase

…blic-key-vote

friedger · 2023-12-01T21:42:33Z

contrib/core-contract-tests/contracts/pox/pox-4-aggregated-public-key.clar

+(define-read-only (current-reward-cycle)
+    u0)
+
+(define-public (vote-for-aggreated-public-key (key (buff 33)) (reward-cycle uint) (round uint) (tapleaves (list 4001 (buff 33))))


@setzeus What must be contained in a vote?

Discussed during 12/5 Clarity WG
Possibly missing hardcoded internal key so we can guarantee that KeyPath isn't spendable.

contrib/core-contract-tests/contracts/pox/pox-4-aggregated-public-key.clar

… feat/pox-4-aggregated-public-key-vote

codecov · 2023-12-16T10:40:41Z

Codecov Report

Attention: 34 lines in your changes are missing coverage. Please review.

Comparison is base (70e8d32) 76.96% compared to head (9966053) 82.78%.
Report is 60 commits behind head on feat/pox-4-disallow-stacking-during-prepare-phase.

Files	Patch %	Lines
stackslib/src/chainstate/stacks/boot/mod.rs	0.00%	31 Missing ⚠️
testnet/stacks-node/src/tests/signer.rs	0.00%	3 Missing ⚠️

Additional details and impacted files

@@                                  Coverage Diff                                  @@
##           feat/pox-4-disallow-stacking-during-prepare-phase    #4116      +/-   ##
=====================================================================================
+ Coverage                                              76.96%   82.78%   +5.82%     
=====================================================================================
  Files                                                    420      421       +1     
  Lines                                                 296655   299227    +2572     
=====================================================================================
+ Hits                                                  228318   247727   +19409     
+ Misses                                                 68337    51500   -16837

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

setzeus · 2023-12-16T18:56:54Z

stackslib/src/chainstate/stacks/boot/pox-4.clar

+    u0)
+
+(define-public (vote-for-aggregated-public-key (key (buff 33)) (reward-cycle uint) (round uint) (tapleaves (list 4001 (buff 33))))


Where is the tally-check / consensus (>70%) update happening?

In sBTC-mini, this function checked if the latest vote pushed an existing signing-key vote above the 70% threshold & updated state accordingly.

Is that logic handled elsewhere at the moment or is that logic missing?

I don't know where to get the weight of a stacker from. Should I rebase on #4164 ?

setzeus · 2023-12-16T19:00:22Z

stackslib/src/chainstate/stacks/boot/pox-4.clar

+(define-map tally {reward-cycle: uint, round: uint, aggregate-public-key: (buff 33)} uint)
+
+(define-constant err-not-allowed (err u10000))


Can you relocate to batch w/ rest of errors & update the format to match existing? (capitalized, currently in the 30s index).

(define-constant ERR_INCORRECT_REWARD_CYCLE 32)

friedger · 2024-01-10T13:20:57Z

Replaced by #4239

blockstack-devops · 2024-11-07T00:22:58Z

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

friedger and others added 17 commits November 23, 2023 14:58

feat: add check-not-prepare-phase to pox-4

a1a6a4c

feat: add check-not-prepare-phase

5ef133e

chore: update boot/pox-4

03e482f

feat: add event for revoke-delegate-stx

6f31254

Merge pull request #4087 from moodmosaic/feat/pox-4-simnet-lease-timi…

8021824

…ng-epoch-2.4 Argon: Pox 4 - Adjust Lease Timing for Epoch 2.4 Compatibility in BNS tests

chore: update boot/pox-4

097830c

chore: synthesise events for revoke-delegate-stx

02ba907

feat: add unit tests in clarity

3757a97

chore: add log file for flow tests

6f3f983

chore: rename synthesize_pox_event_info, fix prepare phase length

915fba7

Merge branch 'next' into feat/pox-4-disallow-stacking-during-prepare-…

14c25bd

…phase

chore: update pox-4-testnet

486366b

chore: add revoke-delegate-stx to get_stacker

7a3a8f7

chore: push package-lock.json

7abb389

feat: add pox-4-aggregated-public-key.clar (WIP)

c4b0ba7

Merge branch 'feat/clarinet-flow-tests' into feat/pox-4-aggregated-pu…

3068fea

…blic-key-vote

friedger commented Dec 1, 2023

View reviewed changes

This was referenced Dec 2, 2023

[stacks-signer] cast_aggregate_public_key vote stx transaction stacks-archive/sbtc-developer-release#392

Closed

[stacks-core] Update .pox-4 to calculate signer key vote shares #4059

Closed

friedger added 3 commits December 3, 2023 13:51

feat: add number of slots to vote

0304f2c

chore: add second state record

117c02a

chore: replace code with pox-4 contract

347804a

jferrant reviewed Dec 11, 2023

View reviewed changes

contrib/core-contract-tests/contracts/pox/pox-4-aggregated-public-key.clar Outdated Show resolved Hide resolved

friedger added 2 commits December 12, 2023 12:39

feat: add check-not-prepare-phase to pox-4

64dbe25

chore: add check for stacking during prepare phase

6ed2a25

friedger force-pushed the feat/pox-4-disallow-stacking-during-prepare-phase branch from ff2c499 to 6ed2a25 Compare December 12, 2023 11:45

chore: re-add deleted code

70e8d32

saralab added the argon3.0 label Dec 12, 2023

saralab added this to the Nakamoto Milestone 0.3 (code name: Argon) milestone Dec 12, 2023

friedger added 4 commits December 13, 2023 15:39

Merge branch 'feat/pox-4-disallow-stacking-during-prepare-phase' into…

6b603a5

… feat/pox-4-aggregated-public-key-vote

chore: fix typo

d7459a3

chore: move vote clar to pox-4

07074b0

chore: improve use of pox-4 boot code

9966053

setzeus mentioned this pull request Dec 16, 2023

pox-4: disallow stacking during prepare phase #4094

Closed

2 tasks

setzeus reviewed Dec 16, 2023

View reviewed changes

friedger changed the base branch from feat/pox-4-disallow-stacking-during-prepare-phase to next January 10, 2024 10:16

friedger changed the base branch from next to chore/pox-4-single-file January 10, 2024 10:17

friedger closed this Jan 10, 2024

blockstack-devops added the locked label Nov 7, 2024

stacks-network locked as resolved and limited conversation to collaborators Nov 7, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Vote for aggregated public key #4116

Vote for aggregated public key #4116

friedger commented Dec 1, 2023

friedger Dec 1, 2023

setzeus Dec 5, 2023

codecov bot commented Dec 16, 2023 •

edited

Loading

setzeus Dec 16, 2023

friedger Dec 18, 2023

setzeus Dec 16, 2023

friedger commented Jan 10, 2024

blockstack-devops commented Nov 7, 2024

		u0)

		(define-public (vote-for-aggregated-public-key (key (buff 33)) (reward-cycle uint) (round uint) (tapleaves (list 4001 (buff 33))))

		(define-map tally {reward-cycle: uint, round: uint, aggregate-public-key: (buff 33)} uint)

		(define-constant err-not-allowed (err u10000))

Vote for aggregated public key #4116

Vote for aggregated public key #4116

Conversation

friedger commented Dec 1, 2023

Description

Applicable issues

Additional info (benefits, drawbacks, caveats)

Checklist

friedger Dec 1, 2023

Choose a reason for hiding this comment

setzeus Dec 5, 2023

Choose a reason for hiding this comment

codecov bot commented Dec 16, 2023 • edited Loading

Codecov Report

setzeus Dec 16, 2023

Choose a reason for hiding this comment

friedger Dec 18, 2023

Choose a reason for hiding this comment

setzeus Dec 16, 2023

Choose a reason for hiding this comment

friedger commented Jan 10, 2024

blockstack-devops commented Nov 7, 2024

codecov bot commented Dec 16, 2023 •

edited

Loading