[clarity] Cast aggregated public key vote

[friedger]

Description

This PR adds clarity code to tally a vote for the aggregated key for each cycle.

Applicable issues

• fixes [Clarity] DKG vote registration  #3968
• fixes [Clarity] fetch vote status per signer per cycle #4060

Additional info (benefits, drawbacks, caveats)

Checklist

• Test coverage for new or modified code paths
• Changelog is updated
• Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
• New clarity functions have corresponding PR in clarity-benchmarking repo
• New integration test(s) added to bitcoin-tests.yml

[jferrant]

Is this meant ot be built off of next? I don't see a corresponding PR for chore/pox-4-single-file

Also make sure it is reabsed off of next and does not contain merge commits. I am seeing lots of unrelated commits / diffs and not sure if that is just because the target branch is not rebased properly on next or if this one was not properly rebased off of next or both.

[friedger]

It is meant to be off the code that contains .signer

[codecov]

Codecov Report

Attention: 55 lines in your changes are missing coverage. Please review.

Comparison is base (d9c1aa1) 52.88% compared to head (0cc9c45) 83.38%.
Report is 8 commits behind head on next.

Files	Patch %	Lines
...src/chainstate/stacks/boot/signers_voting_tests.rs	85.57%	46 Missing ⚠️
libsigner/src/tests/mod.rs	90.69%	4 Missing ⚠️
stackslib/src/clarity_vm/clarity.rs	89.18%	4 Missing ⚠️
stacks-signer/src/runloop.rs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             next    #4239       +/-   ##
===========================================
+ Coverage   52.88%   83.38%   +30.50%     
===========================================
  Files         434      435        +1     
  Lines      308750   309245      +495     
===========================================
+ Hits       163277   257873    +94596     
+ Misses     145473    51372    -94101     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[hstove]

This PR should be updated to merge into next

[kantai]

Just had one comment in the clarity code.

Otherwise, LGTM -- this contract will need to be updated as the stackerdb/signer work changes to support more signers, but that can be handled in a follow-up PR.

[friedger]

Comments addressed

[jferrant]

@kantai aren't we able to vote for DKG at any point in a reward cycle ? @friedger

[friedger]

My understanding was that we need to know the number of slots. This can happen only in the prepare phase. We check that the cycle was set as and registered in .signers.

[jferrant]

Aside from the one change potentially about voting window, I see no issue. We can also always address these sorts of comments in a follow up PR if its better to just merge :)

[blockstack-devops]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.