fix: Contract storage page is still referring to the old cairo syntax #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigant88
changed the title
|
@stoobie : could you help me to fix the build process |
stoobie
merged commit 97a456e
into
starknet-io:bigant88/fix_issue-883
1 of 2 checks passed
stoobie
added a commit
that referenced
this pull request
Nov 28, 2023
) * fix: apply new cairo syntax for Contract storage (#959) * Update components/Starknet/modules/architecture_and_concepts/pages/Smart_Contracts/contract-storage.adoc * Update components/Starknet/modules/architecture_and_concepts/pages/Smart_Contracts/contract-storage.adoc --------- Co-authored-by: Thao Do Van <[email protected]>
stoobie
added a commit
that referenced
this pull request
Nov 28, 2023
stoobie
added a commit
that referenced
this pull request
Nov 28, 2023
#960) (#975) * fix: apply new cairo syntax for Contract storage (#959) * Update components/Starknet/modules/architecture_and_concepts/pages/Smart_Contracts/contract-storage.adoc * Update components/Starknet/modules/architecture_and_concepts/pages/Smart_Contracts/contract-storage.adoc --------- Co-authored-by: Thao Do Van <[email protected]>
stoobie
added a commit
that referenced
this pull request
Nov 28, 2023
* Clarification and edits in Data availabitily * Edits and clarifications * Update components/Starknet/modules/architecture_and_concepts/pages/Network_Architecture/on-chain-data.adoc * Apply suggestions from code review * fix: apply new cairo syntax for Contract storage (Previously #959) (#960) * fix: apply new cairo syntax for Contract storage (#959) * Update components/Starknet/modules/architecture_and_concepts/pages/Smart_Contracts/contract-storage.adoc * Update components/Starknet/modules/architecture_and_concepts/pages/Smart_Contracts/contract-storage.adoc --------- Co-authored-by: Thao Do Van <[email protected]> --------- Co-authored-by: Thao Do Van <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Applied new cairo syntax for Contract storage (maybe someone missed these places)
PR Preview URL
After you push a commit to this PR, a preview is built and a URL to the root of the preview appears in the comment feed.
Paste here the specific URL(s) of the content that this PR addresses.
Check List
<docs/feat/fix/chore>(optional scope): <description>, e.g:fix: minor typos in codeThis change is