Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply new cairo syntax for Contract storage (Previously #959) #960

Merged
merged 4 commits into from
Nov 28, 2023

Conversation

stoobie
Copy link
Collaborator

@stoobie stoobie commented Nov 22, 2023

Description of the Changes

Applied new cairo syntax for Contract storage (maybe someone missed these places)

PR Preview URL

After you push a commit to this PR, a preview is built and a URL to the root of the preview appears in the comment feed.

Paste here the specific URL(s) of the content that this PR addresses.

Check List

  • Changes have been done against dev branch, and PR does not conflict
  • PR title follows the convention: <docs/feat/fix/chore>(optional scope): <description>, e.g: fix: minor typos in code

This change is Reviewable

@stoobie stoobie changed the title fix: apply new cairo syntax for Contract storage (#959) fix: apply new cairo syntax for Contract storage (Previously #959) Nov 22, 2023
Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-960/documentation/ .

Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-960/documentation/ .

@stoobie stoobie requested a review from 0xLucqs November 23, 2023 14:48
@stoobie
Copy link
Collaborator Author

stoobie commented Nov 23, 2023

@LucasLvy Please review

Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-960/documentation/ .

Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-960/documentation/ .

@stoobie stoobie merged commit 0180395 into dev Nov 28, 2023
2 checks passed
@stoobie stoobie deleted the bigant88/fix_issue-883 branch November 28, 2023 07:17
stoobie added a commit that referenced this pull request Nov 28, 2023
@stoobie stoobie restored the bigant88/fix_issue-883 branch November 28, 2023 07:19
@stoobie stoobie deleted the bigant88/fix_issue-883 branch November 28, 2023 07:35
stoobie added a commit that referenced this pull request Nov 28, 2023
#960) (#975)

* fix: apply new cairo syntax for Contract storage (#959)

* Update components/Starknet/modules/architecture_and_concepts/pages/Smart_Contracts/contract-storage.adoc

* Update components/Starknet/modules/architecture_and_concepts/pages/Smart_Contracts/contract-storage.adoc

---------

Co-authored-by: Thao Do Van <[email protected]>
@ArniStarkware
Copy link
Collaborator

:lgtm:

stoobie added a commit that referenced this pull request Nov 28, 2023
* Clarification and edits in Data availabitily

* Edits and clarifications

* Update components/Starknet/modules/architecture_and_concepts/pages/Network_Architecture/on-chain-data.adoc

* Apply suggestions from code review

* fix: apply new cairo syntax for Contract storage (Previously #959) (#960)

* fix: apply new cairo syntax for Contract storage (#959)

* Update components/Starknet/modules/architecture_and_concepts/pages/Smart_Contracts/contract-storage.adoc

* Update components/Starknet/modules/architecture_and_concepts/pages/Smart_Contracts/contract-storage.adoc

---------

Co-authored-by: Thao Do Van <[email protected]>

---------

Co-authored-by: Thao Do Van <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants