Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separated python hint prints for addresses and non-addresses types. #3617

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Separated python hint prints for addresses and non-addresses types. #3617

merged 1 commit into from
Jul 24, 2023

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented Jul 6, 2023 •
edited by spapinistarkware
Loading

@orizi orizi force-pushed the pr/orizi/orizi/signed-ints/dfa86564 branch from ad0d0b4 to c3f6426 Compare July 6, 2023 14:36
This was referenced Jul 6, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@orizi orizi requested a review from spapinistarkware July 6, 2023 14:40
@orizi orizi force-pushed the pr/orizi/orizi/signed-ints/dfa86564 branch 2 times, most recently from 90c54ee to b2b8cd8 Compare July 6, 2023 17:34
@orizi orizi force-pushed the pr/orizi/orizi/signed-ints/96b0d0b5 branch from aef4431 to 949bc06 Compare July 6, 2023 18:02
@orizi orizi force-pushed the pr/orizi/orizi/signed-ints/dfa86564 branch from b2b8cd8 to 137ace6 Compare July 6, 2023 18:02
@orizi orizi changed the base branch from pr/orizi/orizi/signed-ints/96b0d0b5 to main July 6, 2023 18:36
@orizi orizi force-pushed the pr/orizi/orizi/signed-ints/dfa86564 branch 2 times, most recently from cfeba08 to 8c2409f Compare July 9, 2023 04:35
@orizi orizi force-pushed the pr/orizi/orizi/signed-ints/dfa86564 branch from 8c2409f to 9fdab73 Compare July 9, 2023 17:44
spapinistarkware
spapinistarkware reviewed Jul 24, 2023
View reviewed changes
Copy link
Contributor

@spapinistarkware spapinistarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not do %PRIME always?

Reviewed all commit messages.
Reviewable status: 0 of 5 files reviewed, all discussions resolved

spapinistarkware
spapinistarkware approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@spapinistarkware spapinistarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @orizi)

@orizi orizi added this pull request to the merge queue Jul 24, 2023
Merged via the queue into main with commit 6e931d1 Jul 24, 2023
@orizi orizi deleted the pr/orizi/orizi/signed-ints/dfa86564 branch July 24, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spapinistarkware spapinistarkware spapinistarkware approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orizi @spapinistarkware