-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added i*_diff and Ord. #3622
Added i*_diff and Ord. #3622
Conversation
bd9f5c7
to
2bc71f3
Compare
021bc61
to
a53d67d
Compare
5601cda
to
e3e43e2
Compare
a53d67d
to
c739510
Compare
c739510
to
b2a9aef
Compare
e3e43e2
to
35333c6
Compare
b2a9aef
to
88d1a0b
Compare
5326fe3
to
4fba349
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: 0 of 24 files reviewed, 1 unresolved discussion (waiting on @orizi)
corelib/src/integer.cairo
line 1945 at r1 (raw file):
} extern fn i8_diff(lhs: i8, rhs: i8) -> Result<u8, u8> implicits(RangeCheck) nopanic;
Doc the return type. Also possible: Add a new enum for the return type and doc there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 24 of 24 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi)
4fba349
to
ab1acec
Compare
4240bbc
to
a9b4ba3
Compare
c83806e
to
cc62482
Compare
a1f303f
to
5b7795d
Compare
cc62482
to
7d91365
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 18 of 24 files reviewed, 1 unresolved discussion (waiting on @spapinistarkware)
corelib/src/integer.cairo
line 1945 at r1 (raw file):
Previously, spapinistarkware (Shahar Papini) wrote…
Doc the return type. Also possible: Add a new enum for the return type and doc there.
Done.
5b7795d
to
3e07e8b
Compare
7d91365
to
2bc5762
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 6 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @orizi)
3e07e8b
to
da791a8
Compare
2bc5762
to
a703e51
Compare
commit-id:fce91b1f
a703e51
to
aa7a5e3
Compare
Stack:
This change is