Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added i*_diff and Ord. #3622

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Added i*_diff and Ord. #3622

merged 1 commit into from
Jul 25, 2023

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented Jul 6, 2023

Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.


This change is Reviewable

@orizi orizi requested a review from spapinistarkware July 6, 2023 14:41
@orizi orizi force-pushed the pr/orizi/orizi/signed-ints/fce91b1f branch 5 times, most recently from bd9f5c7 to 2bc71f3 Compare July 9, 2023 04:35
@orizi orizi force-pushed the pr/orizi/orizi/signed-ints/7115f73c branch from 021bc61 to a53d67d Compare July 9, 2023 17:44
@orizi orizi force-pushed the pr/orizi/orizi/signed-ints/fce91b1f branch 2 times, most recently from 5601cda to e3e43e2 Compare July 10, 2023 03:27
@orizi orizi force-pushed the pr/orizi/orizi/signed-ints/7115f73c branch from a53d67d to c739510 Compare July 10, 2023 03:27
@orizi orizi force-pushed the pr/orizi/orizi/signed-ints/7115f73c branch from c739510 to b2a9aef Compare July 24, 2023 10:19
@orizi orizi force-pushed the pr/orizi/orizi/signed-ints/fce91b1f branch from e3e43e2 to 35333c6 Compare July 24, 2023 10:19
@orizi orizi force-pushed the pr/orizi/orizi/signed-ints/7115f73c branch from b2a9aef to 88d1a0b Compare July 24, 2023 10:48
@orizi orizi force-pushed the pr/orizi/orizi/signed-ints/fce91b1f branch 2 times, most recently from 5326fe3 to 4fba349 Compare July 24, 2023 11:24
Copy link
Contributor

@spapinistarkware spapinistarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 0 of 24 files reviewed, 1 unresolved discussion (waiting on @orizi)


corelib/src/integer.cairo line 1945 at r1 (raw file):

}

extern fn i8_diff(lhs: i8, rhs: i8) -> Result<u8, u8> implicits(RangeCheck) nopanic;

Doc the return type. Also possible: Add a new enum for the return type and doc there.

Copy link
Contributor

@spapinistarkware spapinistarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 24 of 24 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi)

@orizi orizi force-pushed the pr/orizi/orizi/signed-ints/fce91b1f branch from 4fba349 to ab1acec Compare July 24, 2023 11:39
@orizi orizi force-pushed the pr/orizi/orizi/signed-ints/7115f73c branch from 4240bbc to a9b4ba3 Compare July 24, 2023 12:26
@orizi orizi force-pushed the pr/orizi/orizi/signed-ints/fce91b1f branch 3 times, most recently from c83806e to cc62482 Compare July 24, 2023 13:54
@orizi orizi force-pushed the pr/orizi/orizi/signed-ints/7115f73c branch 2 times, most recently from a1f303f to 5b7795d Compare July 24, 2023 15:00
@orizi orizi force-pushed the pr/orizi/orizi/signed-ints/fce91b1f branch from cc62482 to 7d91365 Compare July 24, 2023 15:00
Copy link
Collaborator Author

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 18 of 24 files reviewed, 1 unresolved discussion (waiting on @spapinistarkware)


corelib/src/integer.cairo line 1945 at r1 (raw file):

Previously, spapinistarkware (Shahar Papini) wrote…

Doc the return type. Also possible: Add a new enum for the return type and doc there.

Done.

@orizi orizi force-pushed the pr/orizi/orizi/signed-ints/7115f73c branch from 5b7795d to 3e07e8b Compare July 25, 2023 14:16
@orizi orizi force-pushed the pr/orizi/orizi/signed-ints/fce91b1f branch from 7d91365 to 2bc5762 Compare July 25, 2023 14:16
Copy link
Contributor

@spapinistarkware spapinistarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 6 of 6 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @orizi)

@orizi orizi force-pushed the pr/orizi/orizi/signed-ints/7115f73c branch from 3e07e8b to da791a8 Compare July 25, 2023 14:40
@orizi orizi force-pushed the pr/orizi/orizi/signed-ints/fce91b1f branch from 2bc5762 to a703e51 Compare July 25, 2023 14:40
commit-id:fce91b1f
@orizi orizi changed the base branch from pr/orizi/orizi/signed-ints/7115f73c to main July 25, 2023 15:02
@orizi orizi force-pushed the pr/orizi/orizi/signed-ints/fce91b1f branch from a703e51 to aa7a5e3 Compare July 25, 2023 15:02
@orizi orizi enabled auto-merge July 25, 2023 15:02
@orizi orizi added this pull request to the merge queue Jul 25, 2023
Merged via the queue into main with commit 35eaa3c Jul 25, 2023
@orizi orizi deleted the pr/orizi/orizi/signed-ints/fce91b1f branch August 10, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants