WIP: update starlink-grpc-go protos, fix build. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The project also fails to build with the current `go.mod`/`go.sum` version for this dependency (see the associated issue[0]). This can be side-stepped by pointing at the right commit of `starlink-community/starlink-grpc-go`, however it introduces a new challenge: Running a router w/ `2022.01.0.mr8624-prod` and a dish w/ `992cafb5-61c7-46a3-9ef7-5907c8cf90fd.uterm.release` the `starlink-community/starlink-grpc-go` generated protobuf types result in incomplete output with "unknown bytes". This PR fixes the build and the incomplete information by temporarily using a fork of `starlink-grpc-go` with updated generated protos. Once the upstream project has merged the updated protos the `replace` directive to use the fork can be removed. With this branch in place I was able to fetch complete information for the software versions on my dish/router. [0]: starlink-community#1
This was referenced Jan 18, 2022
Open
mgrouch
added a commit
to bareboat-necessities/starlink-cli
that referenced
this pull request
Sep 12, 2022
stepga
pushed a commit
to stepga/starlink-cli
that referenced
this pull request
Nov 5, 2024
After picking the pull request [0], go mod tidy has been applied [0] starlink-community#3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The project fails to build with the current
go.mod/go.sumversion for the starlink-grpc-go dependency (see #1). This can be side-stepped by pointing at the right commit ofstarlink-community/starlink-grpc-go, however it introduces a new challenge:Running a router w/
2022.01.0.mr8624-prodand a dish w/992cafb5-61c7-46a3-9ef7-5907c8cf90fd.uterm.releasethestarlink-community/starlink-grpc-gogenerated protobuf types result in incomplete output with "unknown bytes".This PR fixes the build and the incomplete information by temporarily using a fork of
starlink-grpc-gowith updated generated protos. Once the upstream project has merged the updated protos (see starlink-community/starlink-grpc-go#1) thereplacedirective to use the fork can be removed and this PR merged.In the meantime with this branch and its
replacedirective in place I was able to fetch complete information for the software versions on my dish/router with the CLI tool.