update generated proto bindings. #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running `build/get-protoc.sh` gave me an updated `proto/dish.protoset`. My router is running `2022.01.0.mr8624-prod` and my dish is running `992cafb5-61c7-46a3-9ef7-5907c8cf90fd.uterm.release`. Afterwards running `build/regen.sh` fails when compiling `spacex/api/device/dish.proto` due to a missing reference to a `DishConfig` message type. The solution is simple: add another `protoc` line to pull `spacex/api/device/dish_config.proto` out of the descriptor set as well. Now everything builds nicely :-)
|
I opened a draft PR on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
build/get-protoc.shgave me an updatedproto/dish.protoset. My router is running2022.01.0.mr8624-prodand my dish is running992cafb5-61c7-46a3-9ef7-5907c8cf90fd.uterm.release.Afterwards running
build/regen.shfails when compilingspacex/api/device/dish.protodue to a missing reference toa
DishConfigmessage type. The solution is simple: add anotherprotocline to pullspacex/api/device/dish_config.protoout of the descriptor set as well. Now everything builds nicely :-)Before updating these protos running the companion
starlink-cli(after fixing starlink-community/starlink-cli#1) would result in output that had a number of"/* 2 unknown bytes */"type comments.After updating these protos and fixing
starlink-cli'sgo.modto point to this branch I was able to get complete data dumps from my router and dish without any unknown bytes being reported.