feat: fetch user credentials in sdk #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikgb
reviewed
Jan 3, 2025
erikgb
reviewed
Jan 3, 2025
erikgb
reviewed
Jan 3, 2025
| default: | ||
| return nil, fmt.Errorf("error: list credentials unexpected status code: %d", resp.StatusCode) | ||
| } | ||
| } |
There was a problem hiding this comment.
None of the cloudian invoking endpoints have tests. We would have to introduce some interfaces and start mocking or stubbing I guess.
I've only tested curl against the cloudian API docs
There was a problem hiding this comment.
We should probably add some kind of Go REST module that we can easily stub out. Untested code is no good.
Co-authored-by: Erik Godding Boye <[email protected]>
erikgb
approved these changes
Jan 3, 2025
tenstad
reviewed
Jan 6, 2025
| ) | ||
|
|
||
| func TestSecretUnmarshal(t *testing.T) { | ||
| jsonString := `[{"accessKey":"124","secretKey":"x+2","createDate":1735894172440,"active":true}]` |
There was a problem hiding this comment.
Don't think we need to test the builtin go marshalling. Suggesting to simply remove the test.
Obfuscating also seems a bit overkill, as the thing running this has access, and we should not print the thing in production.
tenstad
reviewed
Jan 6, 2025
tenstad
reviewed
Jan 6, 2025
tenstad
reviewed
Jan 6, 2025
Co-authored-by: Amund Tenstad <[email protected]>
Co-authored-by: Amund Tenstad <[email protected]>
|
Merging as-is with both |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.